Bump all jobs to Ubuntu 24.04 Noble #15437
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cameel
reviewed
Sep 18, 2024
nikola-matic
force-pushed
the
bump-all-jobs-to-2404
branch
2 times, most recently
from
dfd8fdd
to
6d65737
Compare
cameel
reviewed
Sep 18, 2024
cameel
reviewed
Sep 18, 2024
docs/docs.sh
Outdated
| @@ -31,5 +31,8 @@ set -euo pipefail | |||
| script_dir="$(dirname "$0")" | |||
|
|
|||
| cd "${script_dir}" | |||
| pip3 install -r requirements.txt --upgrade --upgrade-strategy eager | |||
| # TODO ``--ignore-installed`` now fixes an issue where pip tries to unistnall a debian installed package, but is unable to | |||
There was a problem hiding this comment.
Suggested change
| # TODO ``--ignore-installed`` now fixes an issue where pip tries to unistnall a debian installed package, but is unable to | |
| # TODO `--ignore-installed` now fixes an issue where pip tries to uninstall a Debian installed package, but is unable to |
There was a problem hiding this comment.
BTW, I'd also use just one TODO marker. It looked a bit confusing before I read it carefully - as if there was a bunch of different TODOs here. I'd just indent it instead.
There was a problem hiding this comment.
I prefer a TODO on every line since most IDEs will highlight it a different colour than a regular comment
nikola-matic
force-pushed
the
bump-all-jobs-to-2404
branch
from
6d65737
to
8e53d0a
Compare
nikola-matic
force-pushed
the
bump-all-jobs-to-2404
branch
from
1a91457
to
5fc7269
Compare
cameel
approved these changes
Sep 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.