Translations (do-not-merge) #180
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samajammin
reviewed
Feb 9, 2021
| else: | ||
| is_valid_password = True | ||
|
|
||
| while not is_valid_password: | ||
| password = get_password(text='Type the password that secures your validator keystore(s)') | ||
| password = get_password(text='Type the password that secures your validator keystore(s)') # Translate |
There was a problem hiding this comment.
Let's make it more clear this step creates a password, e.g. "Create a password that will secure your validator keystore(s)"
|
Closing this -> See #182 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(do not merge)
@CarlBeek Hey! So I went through the codebase and made comments as to the strings that we would need to translate for this transition. Also noted some things I don't see the need to mess with, like translating all the flag names, although I'm interested to hear your take on that.
Was hoping you wouldn't mind looking at this and seeing if you had any thought on how we could address this.
Let me know what you think!