Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test compiled executable binaries #198

Merged
merged 1 commit into from
Apr 9, 2021
Merged

Test compiled executable binaries #198

merged 1 commit into from
Apr 9, 2021

Conversation

hwwhww
Copy link
Contributor

@hwwhww hwwhww commented Apr 2, 2021

Fix #137

  • Add test_binary_script.py to test the binary files Basically copied from test_deposit_script.py but plus some edits.
  • Run test_binary_script.py after compiling.

@hwwhww hwwhww added the testing label Apr 2, 2021
@hwwhww hwwhww requested a review from CarlBeek April 5, 2021 05:00
@CarlBeek CarlBeek changed the base branch from master to dev April 8, 2021 15:15
CarlBeek
CarlBeek approved these changes Apr 8, 2021
View reviewed changes
Copy link
Collaborator

@CarlBeek CarlBeek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changed target branch to dev.

LGTM

@hwwhww hwwhww merged commit 5068b92 into dev Apr 9, 2021
@hwwhww hwwhww deleted the test-binaries branch April 9, 2021 07:25
@CarlBeek CarlBeek mentioned this pull request Jun 24, 2021
Merged
everhusk pushed a commit to earthwallet/earth-wallet-cli that referenced this pull request Aug 3, 2023
@hwwhww
Merge pull request ethereum#198 from ethereum/test-binaries
36e101f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CarlBeek CarlBeek CarlBeek approved these changes

Assignees
No one assigned
Labels
testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Test the binaries in CI
2 participants
@hwwhww @CarlBeek