Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update links to the proper releases page #248

Merged
merged 2 commits into from
Mar 16, 2022
Merged

Update links to the proper releases page #248

merged 2 commits into from
Mar 16, 2022

Conversation

marioevz
Copy link
Member

Update links that point to the releases page from
https://github.com/ethereum/staking-deposit-cli/releases
to
https://github.com/ethereum/eth2.0-deposit-cli/releases

CarlBeek
CarlBeek reviewed Mar 16, 2022
View reviewed changes
README.md
```
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

for future reference, the change here is a newline at eof

@CarlBeek CarlBeek changed the base branch from master to dev March 16, 2022 11:11
@CarlBeek
Copy link
Collaborator

thanks @marioevz, i've changed the target to dev as that is our staging branch. it will then get included in the next release.

@CarlBeek CarlBeek merged commit 6adfc6f into ethereum:dev Mar 16, 2022
@marioevz
Copy link
Member Author

Hi @CarlBeek , just wanted to point out I made this change before I knew there was a rename in progress for the repo, is this still valid? The links were pointing to a 404 error page before but I am not sure is still the case with the rename.
Thanks!
Mario.

@CarlBeek
Copy link
Collaborator

No the changes were not relevant. I actually thought the changes were going the other way. (You replaced 'eth2.0' with 'staking', not the other way round.) That said I've already opened a PR that addresses it.

BTW, your 404 was probably because you were looking at dev not master which had unreleased changes.

everhusk pushed a commit to earthwallet/earth-wallet-cli that referenced this pull request Aug 3, 2023
@CarlBeek
Merge pull request ethereum#248 from marioevz/patch-1
55fdba9 
Update links to the proper releases page
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CarlBeek CarlBeek CarlBeek approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@marioevz @CarlBeek