Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validate checksum for eth1_withdrawal_address #338

Merged
merged 2 commits into from
Mar 13, 2023
Merged

Conversation

shicks
Copy link
Contributor

@shicks shicks commented Mar 12, 2023

If the given address is checksummed, the checksum will be validated and will error out eagerly if it's incorrect.

@hwwhww hwwhww changed the base branch from master to dev March 13, 2023 19:35
shicks and others added 2 commits March 14, 2023 03:44
If the given address is checksummed, the checksum will be validated and will error out eagerly if it's incorrect.
Copy link
Contributor

@hwwhww hwwhww left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @shicks 👋

Thank you for making this PR!!
The validation was added in #313 so I fixed the conflicts. The tests are good, I just changed the scripts since it now asks the user to re-type and confirms their eth1_withdrawal_address input.

@hwwhww hwwhww merged commit 395f813 into ethereum:dev Mar 13, 2023
everhusk pushed a commit to earthwallet/earth-wallet-cli that referenced this pull request Aug 3, 2023
Validate checksum for eth1_withdrawal_address
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants