Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add network (chain) name selection to prompt #61

Merged
merged 1 commit into from
Jul 27, 2020
Merged

Conversation

hwwhww
Copy link
Contributor

@hwwhww hwwhww commented Jul 27, 2020

Issue

It seems many Medalla users didn't set the chain (network) name with flags. This PR sets chain/network selection to prompt requests.

How did I fix it

Add prompt string:

Please choose the (mainnet or testnet) network/chain name (mainnet, witti, altona, medalla) [mainnet]

@hwwhww hwwhww added the enhancement New feature or request label Jul 27, 2020
@hwwhww hwwhww force-pushed the hwwhww/network-selection branch from faddcd0 to 01bede3 Compare July 27, 2020 16:12
@hwwhww
Copy link
Contributor Author

hwwhww commented Jul 27, 2020

Finger-crossed merging it.

@hwwhww hwwhww changed the base branch from master to dev July 27, 2020 16:31
@hwwhww hwwhww force-pushed the hwwhww/network-selection branch from 01bede3 to f9fd7a1 Compare July 27, 2020 16:32
@hwwhww hwwhww merged commit 55b8950 into dev Jul 27, 2020
@CarlBeek CarlBeek deleted the hwwhww/network-selection branch September 22, 2020 11:08
everhusk pushed a commit to earthwallet/earth-wallet-cli that referenced this pull request Aug 3, 2023
Add network (chain) name selection to prompt
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant