Tests for EIP-3651: Warm COINBASE #1082
Conversation
marioevz
force-pushed
the
eip-3651-tests
branch
from
76d72dd to
86983e5
Compare
|
What is the status of this? |
marioevz
force-pushed
the
eip-3651-tests
branch
from
86983e5 to
48682d2
Compare
|
@winsvega I refilled these tests with latest ethereum/retesteth@faead84 and updated the yul code because it was being optimized by |
|
Add vectors to /src/readme |
Added, let me know if the format of the descriptions is ok. |
|
|
||
| ## Warm COINBASE EIP-3651 | ||
|
|
||
| - ID: **WRMCB0001** check EXTCODESIZE gas cost on coinbase |
There was a problem hiding this comment.
the same key should also be mentioned in the test file in comments or in info section comment field. so we can find the test.
if one test contains many test vectors ids implementation can put a comment right next to the block that executes a scenario (for bc tests) or transaction data that implements it.
In yml comments supported by format with #
In json fillers any field started with "//" is deleted
|
ready? |
marioevz
force-pushed
the
eip-3651-tests
branch
from
61cefbe to
36aa3d5
Compare
Changes included
Adds tests for Shanghai fork upgrade EIP-3651.
Coinbase account is now warm and is by default added to the
accessed_addresseslist when the transaction starts execution.We test accessing the account with the following opcodes:
Requires
Shanghaifork to be added to retesteth.