Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

create2 collision tests #486

Merged
merged 2 commits into from
Aug 28, 2018
Merged

create2 collision tests #486

merged 2 commits into from
Aug 28, 2018

Conversation

winsvega
Copy link
Collaborator

@winsvega winsvega commented Aug 15, 2018 •
edited
Loading

@winsvega winsvega mentioned this pull request Aug 15, 2018
Merged
12 tasks
@cburgdorf cburgdorf mentioned this pull request Aug 15, 2018
Merged
@cburgdorf
Copy link

@winsvega are these test cases already based on the latest address format that was decided in the last core dev call?

@winsvega
Copy link
Collaborator Author

Yes

@holgerd77
Copy link
Contributor

Cool! 👍 Can we please please always have the "comment" field filled out on new tests?

@winsvega
Copy link
Collaborator Author

Yes. Thanks for mentioning it

@winsvega winsvega force-pushed the create2 branch 2 times, most recently from 6484a42 to 4e18fcf Compare August 21, 2018 15:15
@winsvega winsvega changed the title create2 test create2 collision tests Aug 21, 2018
@winsvega winsvega force-pushed the create2 branch 2 times, most recently from 50e872f to ce909b4 Compare August 27, 2018 12:37
@winsvega winsvega merged commit e25d230 into develop Aug 28, 2018
@axic axic deleted the create2 branch August 28, 2018 12:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@winsvega @cburgdorf @holgerd77