Add new touched cleanup case #500
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
use --filltests --fillchain to create a copy of this test for hive. |
Regression test for ethereumjs/ethereumjs-monorepo#335 First call marks an empty account as touched. Second call errors OOG. Transaction should still cleanup empty account.
mattdean-digicatapult
force-pushed
the
add-new-touched-cleanup-case
branch
from
1c894d4 to
3ce22f9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Regression test associated with ethereumjs/ethereumjs-monorepo#335
First call marks an empty account as touched. Second call errors OOG. Transaction should still cleanup empty account.
This fails in ethereumjs-vm due to the incorrect handling of the touched set when an error occurs.
Apologies if I've put this in the wrong place, this is my first time writing an evm test case and I was just feeling around a bit for conventions.