Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

EIP1559 state tests, using the new expectException: #875

Merged
merged 8 commits into from
Jun 11, 2021
Merged

EIP1559 state tests, using the new expectException: #875

merged 8 commits into from
Jun 11, 2021

Conversation

qbzzt
Copy link
Collaborator

@qbzzt qbzzt commented Jun 6, 2021

No description provided.

@qbzzt qbzzt added the ready-to-merge PR is ready to merge and not WIP label Jun 6, 2021
@qbzzt qbzzt mentioned this pull request Jun 6, 2021
Closed
@qbzzt qbzzt linked an issue Jun 6, 2021 that may be closed by this pull request
Tests for 1559 extended requirements #868
Closed
@qbzzt qbzzt removed the ready-to-merge PR is ready to merge and not WIP label Jun 6, 2021
@qbzzt
Copy link
Collaborator Author

qbzzt commented Jun 6, 2021

I removed ready-to-merge because I want to test more things in lowIntrinsic

qbzzt added 3 commits June 6, 2021 20:50
@qbzzt
Delete lowIntrinsic.json
8a663a5 
Postponed to a different PR because I want to do it with a generator and that'll take me a few days.
@qbzzt
Delete lowIntrinsic.json
1a1a2b1 
Postponed to a different PR because I want to do it with a generator and that'll take me a few days.
@qbzzt
Delete lowIntrinsicFiller.yml
8f5c52d 
Postponed to a different PR because I want to do it with a generator and that'll take me a few days.
@qbzzt qbzzt added the ready-to-merge PR is ready to merge and not WIP label Jun 7, 2021
@qbzzt
Copy link
Collaborator Author

qbzzt commented Jun 7, 2021

I decided it makes more sense to merge the seven tests that are already written, one of which (lowGasLimit) already checks intrinsic costs. The full intrinsic test will take a few days to write, because I'm going to write it with a generator. Otherwise it would take too long.

winsvega
winsvega requested changes Jun 9, 2021
View reviewed changes
Copy link
Collaborator

@winsvega winsvega left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

refill tests

@winsvega winsvega removed the ready-to-merge PR is ready to merge and not WIP label Jun 9, 2021
@qbzzt qbzzt added the ready-to-merge PR is ready to merge and not WIP label Jun 10, 2021
@winsvega winsvega merged commit 1bf12ce into develop Jun 11, 2021
@winsvega winsvega deleted the eip1559-state-test branch June 11, 2021 11:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@winsvega winsvega winsvega approved these changes

Assignees
No one assigned
Labels
ready-to-merge PR is ready to merge and not WIP
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Tests for 1559 extended requirements
2 participants
@qbzzt @winsvega