This repository has been archived by the owner on Jul 1, 2021. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 146
Do not skip tests for IstanbulVM #1372
Merged
cburgdorf
merged 5 commits into
ethereum:master
from
cburgdorf:christoph/fix/do-not-skip-istanbul-tests
Dec 20, 2019
Merged
Do not skip tests for IstanbulVM #1372
cburgdorf
merged 5 commits into
ethereum:master
from
cburgdorf:christoph/fix/do-not-skip-istanbul-tests
Dec 20, 2019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cburgdorf
force-pushed
the
christoph/fix/do-not-skip-istanbul-tests
branch
2 times, most recently
from
December 12, 2019 13:32
3b2886f
to
41bac4b
Compare
cburgdorf
force-pushed
the
christoph/fix/do-not-skip-istanbul-tests
branch
2 times, most recently
from
December 18, 2019 13:33
39e0d52
to
6b827b0
Compare
cburgdorf
force-pushed
the
christoph/fix/do-not-skip-istanbul-tests
branch
from
December 18, 2019 14:03
e0040f0
to
ed9b214
Compare
2 tasks
cburgdorf
force-pushed
the
christoph/fix/do-not-skip-istanbul-tests
branch
3 times, most recently
from
December 18, 2019 14:21
ed9b214
to
e0040f0
Compare
ethereum/py-evm#1852 (comment) (It is slow, true, but it also crashes the CI box because it consumes a lot of memory.) In fact, I wonder if |
cburgdorf
force-pushed
the
christoph/fix/do-not-skip-istanbul-tests
branch
2 times, most recently
from
December 18, 2019 15:16
552895a
to
f10d60a
Compare
@veox Thanks for chiming in!
Generally a good idea I'd say but I'm not sure if it's possible as is because the tests aren't real modules (as in, they don't have a |
Argh, I keep forgetting. |
veox
reviewed
Dec 18, 2019
cburgdorf
force-pushed
the
christoph/fix/do-not-skip-istanbul-tests
branch
from
December 18, 2019 16:47
f10d60a
to
c14a32a
Compare
pipermerriam
approved these changes
Dec 20, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was wrong?
We aren't testing Trinity against Istanbul yet.
How was it fixed?
To-Do
Cute Animal Picture