Skip to content
This repository has been archived by the owner on Jul 1, 2021. It is now read-only.

Do not skip tests for IstanbulVM #1372

Merged

Conversation

cburgdorf
Copy link
Contributor

@cburgdorf cburgdorf commented Dec 9, 2019

What was wrong?

We aren't testing Trinity against Istanbul yet.

How was it fixed?

To-Do

  • Clean up commit history

Cute Animal Picture

put a cute animal picture link inside the parentheses

@cburgdorf cburgdorf force-pushed the christoph/fix/do-not-skip-istanbul-tests branch 2 times, most recently from 3b2886f to 41bac4b Compare December 12, 2019 13:32
@cburgdorf cburgdorf force-pushed the christoph/fix/do-not-skip-istanbul-tests branch 2 times, most recently from 39e0d52 to 6b827b0 Compare December 18, 2019 13:33
@cburgdorf cburgdorf force-pushed the christoph/fix/do-not-skip-istanbul-tests branch from e0040f0 to ed9b214 Compare December 18, 2019 14:03
@cburgdorf cburgdorf force-pushed the christoph/fix/do-not-skip-istanbul-tests branch 3 times, most recently from ed9b214 to e0040f0 Compare December 18, 2019 14:21
@veox
Copy link
Contributor

veox commented Dec 18, 2019

randomStatetest94 is OK to be tagged SLOW, IMO:

ethereum/py-evm#1852 (comment)

(It is slow, true, but it also crashes the CI box because it consumes a lot of memory.)


In fact, I wonder if SLOWEST_TESTS should just be imported from py-evm, and then amended with more cases (that are only run in trinity).

@cburgdorf cburgdorf force-pushed the christoph/fix/do-not-skip-istanbul-tests branch 2 times, most recently from 552895a to f10d60a Compare December 18, 2019 15:16
@cburgdorf
Copy link
Contributor Author

@veox Thanks for chiming in!

In fact, I wonder if SLOWEST_TESTS should just be imported from py-evm

Generally a good idea I'd say but I'm not sure if it's possible as is because the tests aren't real modules (as in, they don't have a __init__.py file) so we can't import from them and if I recall correctly there is some obscure pytest reason for that.

@veox
Copy link
Contributor

veox commented Dec 18, 2019

... so we can't import from them ...

Argh, I keep forgetting.

tox.ini Outdated Show resolved Hide resolved
@cburgdorf cburgdorf force-pushed the christoph/fix/do-not-skip-istanbul-tests branch from f10d60a to c14a32a Compare December 18, 2019 16:47
@cburgdorf cburgdorf merged commit aef3ad1 into ethereum:master Dec 20, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants