-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rename geth_poa_middleware to something more generic #899
Labels
Comments
The geth poa middleware makes some assumptions about what the Maybe something like: def construct_move_extraData(rename_to='nonStandardExtraData'):
...
move_extraData_middleware = construct_move_extraData() geth_poa_middleware = construct_move_extraData(rename_to='proofOfAuthorityData')
The middleware approach seems fine. |
fselmo
added a commit
to fselmo/web3.py
that referenced
this issue
Dec 15, 2023
- The middleware changed names in the refactor, but this commit puts the finishing touches and closes ethereum#899
2 tasks
fselmo
added a commit
to fselmo/web3.py
that referenced
this issue
Dec 15, 2023
- The middleware changed names in the refactor, but this commit puts the finishing touches and closes ethereum#899
fselmo
added a commit
to fselmo/web3.py
that referenced
this issue
Dec 15, 2023
- The middleware changed names in the refactor, but this commit puts the finishing touches and closes ethereum#899
fselmo
added a commit
to fselmo/web3.py
that referenced
this issue
Dec 15, 2023
- The middleware changed names in the refactor, but this commit puts the finishing touches and closes ethereum#899
fselmo
added a commit
to fselmo/web3.py
that referenced
this issue
Jan 16, 2024
- The middleware changed names in the refactor, but this commit puts the finishing touches and closes ethereum#899
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
What was wrong?
It seems like many other chains have set higher length for
extraData
. see #898How can it be fixed?
Should
geth_poa_middleware
be renamed to something likelong_extraData_middleware
? Or could the extraData length be configurable?The text was updated successfully, but these errors were encountered: