Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rename geth_poa_middleware to something more generic #899

Closed
dylanjw opened this issue Jun 12, 2018 · 1 comment · Fixed by #3169
Closed

rename geth_poa_middleware to something more generic #899

dylanjw opened this issue Jun 12, 2018 · 1 comment · Fixed by #3169

Comments

@dylanjw
Copy link
Contributor

dylanjw commented Jun 12, 2018

What was wrong?

It seems like many other chains have set higher length for extraData. see #898

How can it be fixed?

Should geth_poa_middleware be renamed to something like long_extraData_middleware? Or could the extraData length be configurable?

@carver
Copy link
Collaborator

carver commented Jun 12, 2018

Should geth_poa_middleware be renamed to something like long_extraData_middleware?

The geth poa middleware makes some assumptions about what the extraData is (naming it proof of authority).

Maybe something like:

def construct_move_extraData(rename_to='nonStandardExtraData'):
    ...

move_extraData_middleware = construct_move_extraData()
geth_poa_middleware = construct_move_extraData(rename_to='proofOfAuthorityData')

Or could the extraData length be configurable?

The middleware approach seems fine.

@fselmo fselmo self-assigned this Oct 9, 2023
fselmo added a commit to fselmo/web3.py that referenced this issue Dec 15, 2023
- The middleware changed names in the refactor, but this commit puts the finishing touches and closes ethereum#899
fselmo added a commit to fselmo/web3.py that referenced this issue Dec 15, 2023
- The middleware changed names in the refactor, but this commit puts the finishing touches and closes ethereum#899
fselmo added a commit to fselmo/web3.py that referenced this issue Dec 15, 2023
- The middleware changed names in the refactor, but this commit puts the finishing touches and closes ethereum#899
fselmo added a commit to fselmo/web3.py that referenced this issue Dec 15, 2023
- The middleware changed names in the refactor, but this commit puts the finishing touches and closes ethereum#899
fselmo added a commit to fselmo/web3.py that referenced this issue Jan 16, 2024
- The middleware changed names in the refactor, but this commit puts the finishing touches and closes ethereum#899
@fselmo fselmo closed this as completed in b0c0173 Jan 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants