Reuse IPC Socket #356
Merged
Reuse IPC Socket #356
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
See openethereum/parity-ethereum#6516 Thanks @iFA88 for kicking this off!
|
Just realized you might not be done with this... Either way, looks good. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was wrong?
When making many consecutive requests over IPC, they were slow, used a lot of RAM, and eventually crashed Parity. See openethereum/parity-ethereum#6516
How was it fixed?
Reuse IPC connection across requests.
Thanks @iFA88 for testing out that the approach has a significant performance boost.
Cute Animal Picture