Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ecip-1066.md #526

Merged
merged 4 commits into from
May 22, 2024
Merged

Update ecip-1066.md #526

merged 4 commits into from
May 22, 2024

Conversation

chris-mercer
Copy link
Member

Add Spiral

@chris-mercer chris-mercer requested a review from a team February 16, 2024 00:52
_specs/ecip-1066.md Outdated Show resolved Hide resolved
Co-authored-by: Chris Ziogas <ziogas_chr@hotmail.com>
@meowsbits
Copy link
Member

I would like more descriptive commits and branch name (@chris-mercer especially since you're pushing directly to the ethereumclassic remote). Without viewing the patch itself I have no idea what's going on here.

Add the Spiral Upgrade details to the list following the information provided in ECIP-1109. This upgrade went live on Feb 4, 2024.
@gitr0n1n
Copy link
Contributor

I would like more descriptive commits and branch name (@chris-mercer especially since you're pushing directly to the ethereumclassic remote). Without viewing the patch itself I have no idea what's going on here.

Done! 7c210cf6e166e30992f8a6f77ec5f36289784e47

@meowsbits
Copy link
Member

Cool thanks 👍

@realcodywburns
Copy link
Member

realcodywburns commented Mar 5, 2024

How was eip-6049 implemented? It is not included in the 'expected action' portion and the spec is dubious + poorly defined. My understanding is this is a warning in documentation(?) to not use selfdestruct. As written, 6049 opens the door to reuse the opcode for something that a contract may not have intended when deployed. In the comments in geth it looks like we will eventually treat it as a noop after the activation block. I would recommend having it as a permanent 'noop' and not be allowed to be repurposed. ack this flag allows compatibility with eth. Its implementation or lack there of is included in this ecip update

@meowsbits
Copy link
Member

In core-geth IsEIP6049 is inoperative; it's just a paper placeholder, and afaiu that's the spec. Duly noted on the suggestion to permanent noop it.

@realcodywburns
Copy link
Member

Sounds good to me. can we squash merge this now?

@realcodywburns realcodywburns merged commit 3c1ee32 into master May 22, 2024
4 checks passed
@realcodywburns realcodywburns deleted the chris-mercer-patch-1 branch May 22, 2024 10:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants