Skip to content
This repository has been archived by the owner on Apr 6, 2020. It is now read-only.

[Constantinople] Added difficulty bomb delay (EIP1234) #54

Merged
merged 2 commits into from
Oct 18, 2018

Conversation

alextsg
Copy link
Contributor

@alextsg alextsg commented Sep 29, 2018

Fixes #53

@alextsg
Copy link
Contributor Author

alextsg commented Sep 29, 2018

@holgerd77 I'm not sure what's the best way to add tests here, as I don't think difficultyConstantinople.json exists yet on ethereum/tests.

@coveralls
Copy link

coveralls commented Sep 29, 2018

Coverage Status

Coverage increased (+0.5%) to 73.818% when pulling d9de788 on alextsg:eip1234 into dbe2ffb on ethereumjs:master.

@alextsg alextsg changed the title Added Constantinople difficulty bomb delay Added Constantinople difficulty bomb delay (EIP1234) Sep 29, 2018
@alextsg alextsg changed the title Added Constantinople difficulty bomb delay (EIP1234) [Constantinople] Added difficulty bomb delay (EIP1234) Sep 29, 2018
@holgerd77
Copy link
Member

Hmm, not sure, have asked here: ethereum/tests#318

There is also this spreadsheet with the state of tests, difficulty section seems to be outdated though.

@alextsg
Copy link
Contributor Author

alextsg commented Oct 1, 2018

Thanks @holgerd77. It sounds like tests are coming soon so I'll keep a lookout for that.

@holgerd77
Copy link
Member

Difficulty tests for Constantinople are now merged, see new difficultyConstantinople.json file over on the ethereum/tests repo, so we can use this now for testing here in the library.

@holgerd77
Copy link
Member

Hi @alextsg, I've now also released a new version v0.6.0 of the ethereumjs-common library including the miner reward parameter changes PR.

@alextsg
Copy link
Contributor Author

alextsg commented Oct 11, 2018

Great, thanks @holgerd77! Will finish this up soon.

@holgerd77
Copy link
Member

Hi Alex, if you could update here would be great, then we could finish this part up! 😃

@alextsg
Copy link
Contributor Author

alextsg commented Oct 18, 2018

Sorry about that! Updated

Copy link
Member

@holgerd77 holgerd77 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks! 😀

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants