Fix blockchain tests

This fixes the last set of blockchain tests:

* RPC_API_Test
* randomStatetest224BC
* randomStatetest234BC
* randomStatetest529BC
* ExtraData32
* log1_correct
* timeDiff0
* timeDiff12
* timeDiff13
* timeDiff14

These were mostly caused by missing block validation and the intentional disparity between the bloom filter implementation and the yellow paper introduced in #295.

lib/bloom.js

@@ -2,20 +2,6 @@ const assert = require('assert')
 const utils = require('ethereumjs-util')
 const byteSize = 256
 
-/**
- * Drops leading zeroes from a buffer
- * @function dropLeadingZeroes
- * @param {Buffer} buff
- * @returns {Buffer} a slice of the given buffer starting at the first non-zero entry
- */
-function dropLeadingZeroes (buff) {
-  for (var i = 0; i < buff.length; i++) {
-    if (buff[i] !== 0) {
-      return buff.slice(i)
-    }
-  }
-}
-
 /**
  * Represents a Bloom
  * @constructor
@@ -36,7 +22,7 @@ var Bloom = module.exports = function (bitvector) {
  * @param {Buffer} e the element to add
  */
 Bloom.prototype.add = function (e) {
-  e = utils.keccak256(dropLeadingZeroes(e))
+  e = utils.keccak256(e)
   var mask = 2047 // binary 11111111111
 
   for (var i = 0; i < 3; i++) {
@@ -55,7 +41,7 @@ Bloom.prototype.add = function (e) {
  * @returns {boolean} Returns {@code true} if the element is in the bloom
  */
 Bloom.prototype.check = function (e) {
-  e = utils.keccak256(dropLeadingZeroes(e))
+  e = utils.keccak256(e)
   var mask = 2047 // binary 11111111111
   var match = true
 

lib/runBlock.js

@@ -36,6 +36,7 @@ module.exports = function (opts, cb) {
 
   // parse options
   const block = opts.block
+  const skipBlockValidation = opts.skipBlockValidation || false
   const generateStateRoot = !!opts.generate
   const validateStateRoot = !generateStateRoot
   const bloom = new Bloom()
@@ -80,10 +81,14 @@ module.exports = function (opts, cb) {
   }
 
   function validateBlock (cb) {
-    if (new BN(block.header.gasLimit).gte(new BN('8000000000000000', 16))) {
-      cb(new Error('Invalid block with gas limit greater than (2^63 - 1)'))
-    } else {
+    if (skipBlockValidation) {
       cb()
+    } else {
+      if (new BN(block.header.gasLimit).gte(new BN('8000000000000000', 16))) {
+        cb(new Error('Invalid block with gas limit greater than (2^63 - 1)'))
+      } else {
+        block.validate(self.blockchain, cb)
+      }
     }
   }