develop: ci fix, some last backwards compatibility removals #1834
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Flags with carried forward coverage won't be shown. Click here to find out more. |
|
I noticed a series of my commits missing from my prior PR #1815:
Highlighted here:
So I have cherry-picked them and added them back to this PR. |
…chain karma.conf.js (karma has trouble with the default browser esm import without es6 transform, so it is easier to tell it to use umd)
… need to init one here
holgerd77
force-pushed
the
develop-ci-fix
branch
from
c815ef8 to
5e9da55
Compare
|
Rebased this via UI with a local test rebase before. |
holgerd77
approved these changes
Apr 5, 2022
| @@ -284,9 +283,7 @@ export default class VM extends AsyncEventEmitter { | |||
| if (opts.stateManager) { | |||
| this.stateManager = opts.stateManager | |||
| } else { | |||
| const trie = new Trie() | |||
| @@ -104,7 +104,7 @@ export class Trie { | |||
| */ | |||
| async checkRoot(root: Buffer): Promise<boolean> { | |||
| try { | |||
| const value = await this._lookupNode(root) | |||
| const value = await this.lookupNode(root) | |||
There was a problem hiding this comment.
We didn't plan to do a breaking Trie release initially, but my previously somewhat stronger opinion on this is wayning, so we might just do along (and then also finally do the renaming).
Just wanted to mention here. We then eventually want to have one additional thought round or broader look on other breaking changes.
There was a problem hiding this comment.
So, some additional context: currently Trie is still listed in the "Future Release Planning" issue: #1718. Should I move over? 🤔
There was a problem hiding this comment.
ah sorry didn't notice that.
yeah sure let's include these refactorings, i think now is the time to do it while we are preparing develop. not sure if it makes sense to wait any longer. we can assign some team members to the tasks and i can also dedicate some time this month to tackle them.
| ]) | ||
| ) | ||
| ) | ||
| receiptsSize += Buffer.byteLength(receiptsBuffer) |
There was a problem hiding this comment.
Could you drop a short note what's happening here?
Does this fix some concrete issues? Can't oversee this on a first look.
There was a problem hiding this comment.
ah yeah, actually you commented on an old version of this code, if you look at the final state in this PR i made it much more simple by using our existing encodeReceipt function. this is simply keeping track of the size of the GetReceipts devp2p response, so we can respect capping at 10mib as the spec suggests.
holgerd77
pushed a commit
that referenced
this pull request
Apr 5, 2022
* move ethash depBrowserWorkaround fix for bigint-crypto-utils to blockchain karma.conf.js (karma has trouble with the default browser esm import without es6 transform, so it is easier to tell it to use umd) * new DefaultStateManager will init a trie if not supplied, so we don't need to init one here * remove backwards compatibility note (we will keep this property) * trie: remove old backwards compat methods * client: do undefined check first * vm: undo doc change * client: improve receipt size calculation * vm: resolve more todos * vm: more hardfork enum usage * dedupe receipt rlp encoding * lint * runCall, runCode: add more param typedocs, simplify * also add karma workaround to vm
holgerd77
pushed a commit
that referenced
this pull request
Apr 7, 2022
* move ethash depBrowserWorkaround fix for bigint-crypto-utils to blockchain karma.conf.js (karma has trouble with the default browser esm import without es6 transform, so it is easier to tell it to use umd) * new DefaultStateManager will init a trie if not supplied, so we don't need to init one here * remove backwards compatibility note (we will keep this property) * trie: remove old backwards compat methods * client: do undefined check first * vm: undo doc change * client: improve receipt size calculation * vm: resolve more todos * vm: more hardfork enum usage * dedupe receipt rlp encoding * lint * runCall, runCode: add more param typedocs, simplify * also add karma workaround to vm
g11tech
pushed a commit
that referenced
this pull request
Apr 29, 2022
* move ethash depBrowserWorkaround fix for bigint-crypto-utils to blockchain karma.conf.js (karma has trouble with the default browser esm import without es6 transform, so it is easier to tell it to use umd) * new DefaultStateManager will init a trie if not supplied, so we don't need to init one here * remove backwards compatibility note (we will keep this property) * trie: remove old backwards compat methods * client: do undefined check first * vm: undo doc change * client: improve receipt size calculation * vm: resolve more todos * vm: more hardfork enum usage * dedupe receipt rlp encoding * lint * runCall, runCode: add more param typedocs, simplify * also add karma workaround to vm
holgerd77
pushed a commit
that referenced
this pull request
May 4, 2022
* move ethash depBrowserWorkaround fix for bigint-crypto-utils to blockchain karma.conf.js (karma has trouble with the default browser esm import without es6 transform, so it is easier to tell it to use umd) * new DefaultStateManager will init a trie if not supplied, so we don't need to init one here * remove backwards compatibility note (we will keep this property) * trie: remove old backwards compat methods * client: do undefined check first * vm: undo doc change * client: improve receipt size calculation * vm: resolve more todos * vm: more hardfork enum usage * dedupe receipt rlp encoding * lint * runCall, runCode: add more param typedocs, simplify * also add karma workaround to vm
g11tech
pushed a commit
that referenced
this pull request
Jun 2, 2022
* move ethash depBrowserWorkaround fix for bigint-crypto-utils to blockchain karma.conf.js (karma has trouble with the default browser esm import without es6 transform, so it is easier to tell it to use umd) * new DefaultStateManager will init a trie if not supplied, so we don't need to init one here * remove backwards compatibility note (we will keep this property) * trie: remove old backwards compat methods * client: do undefined check first * vm: undo doc change * client: improve receipt size calculation * vm: resolve more todos * vm: more hardfork enum usage * dedupe receipt rlp encoding * lint * runCall, runCode: add more param typedocs, simplify * also add karma workaround to vm
g11tech
pushed a commit
that referenced
this pull request
Jun 2, 2022
* move ethash depBrowserWorkaround fix for bigint-crypto-utils to blockchain karma.conf.js (karma has trouble with the default browser esm import without es6 transform, so it is easier to tell it to use umd) * new DefaultStateManager will init a trie if not supplied, so we don't need to init one here * remove backwards compatibility note (we will keep this property) * trie: remove old backwards compat methods * client: do undefined check first * vm: undo doc change * client: improve receipt size calculation * vm: resolve more todos * vm: more hardfork enum usage * dedupe receipt rlp encoding * lint * runCall, runCode: add more param typedocs, simplify * also add karma workaround to vm
g11tech
pushed a commit
that referenced
this pull request
Jun 2, 2022
* move ethash depBrowserWorkaround fix for bigint-crypto-utils to blockchain karma.conf.js (karma has trouble with the default browser esm import without es6 transform, so it is easier to tell it to use umd) * new DefaultStateManager will init a trie if not supplied, so we don't need to init one here * remove backwards compatibility note (we will keep this property) * trie: remove old backwards compat methods * client: do undefined check first * vm: undo doc change * client: improve receipt size calculation * vm: resolve more todos * vm: more hardfork enum usage * dedupe receipt rlp encoding * lint * runCall, runCode: add more param typedocs, simplify * also add karma workaround to vm
g11tech
pushed a commit
that referenced
this pull request
Jun 3, 2022
* move ethash depBrowserWorkaround fix for bigint-crypto-utils to blockchain karma.conf.js (karma has trouble with the default browser esm import without es6 transform, so it is easier to tell it to use umd) * new DefaultStateManager will init a trie if not supplied, so we don't need to init one here * remove backwards compatibility note (we will keep this property) * trie: remove old backwards compat methods * client: do undefined check first * vm: undo doc change * client: improve receipt size calculation * vm: resolve more todos * vm: more hardfork enum usage * dedupe receipt rlp encoding * lint * runCall, runCode: add more param typedocs, simplify * also add karma workaround to vm
holgerd77
pushed a commit
that referenced
this pull request
Jun 8, 2022
* move ethash depBrowserWorkaround fix for bigint-crypto-utils to blockchain karma.conf.js (karma has trouble with the default browser esm import without es6 transform, so it is easier to tell it to use umd) * new DefaultStateManager will init a trie if not supplied, so we don't need to init one here * remove backwards compatibility note (we will keep this property) * trie: remove old backwards compat methods * client: do undefined check first * vm: undo doc change * client: improve receipt size calculation * vm: resolve more todos * vm: more hardfork enum usage * dedupe receipt rlp encoding * lint * runCall, runCode: add more param typedocs, simplify * also add karma workaround to vm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes an issue in develop where a karma workaround was erroring in the hardhat e2e installation for our packages. I moved the fix to the blockchain karma config.
I also executed some final breaking change items in VM and Trie.