trie: convert constructor to options interface, remove deprecated setRoot #1874
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Flags with carried forward coverage won't be shown. Click here to find out more. |
holgerd77
approved these changes
May 2, 2022
| @@ -735,7 +750,7 @@ export class Trie { | |||
| */ | |||
| copy(): Trie { | |||
| const db = this.db.copy() | |||
| return new Trie(db._leveldb, this.root) | |||
| return new Trie({ db: db._leveldb, root: this.root, deleteFromDB: this._deleteFromDB }) | |||
There was a problem hiding this comment.
Ah, that's all a lot nicer, great to see this. 👍 🙂
holgerd77
pushed a commit
that referenced
this pull request
May 4, 2022
…Root (#1874) * trie: add constructor options interface * remove assert use, remove deprecated setRoot
g11tech
pushed a commit
that referenced
this pull request
Jun 2, 2022
…Root (#1874) * trie: add constructor options interface * remove assert use, remove deprecated setRoot
g11tech
pushed a commit
that referenced
this pull request
Jun 2, 2022
…Root (#1874) * trie: add constructor options interface * remove assert use, remove deprecated setRoot
g11tech
pushed a commit
that referenced
this pull request
Jun 2, 2022
…Root (#1874) * trie: add constructor options interface * remove assert use, remove deprecated setRoot
g11tech
pushed a commit
that referenced
this pull request
Jun 3, 2022
…Root (#1874) * trie: add constructor options interface * remove assert use, remove deprecated setRoot
holgerd77
pushed a commit
that referenced
this pull request
Jun 8, 2022
…Root (#1874) * trie: add constructor options interface * remove assert use, remove deprecated setRoot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Completes tasks in #1717:
Trie.setRoot()functionextra:
assertusage, preferring normal errors