Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

client: snap protocol tests #2119

Merged
merged 2 commits into from
Aug 10, 2022
Merged

client: snap protocol tests #2119

merged 2 commits into from
Aug 10, 2022

Conversation

scorbajio
Copy link
Contributor

This PR adds tests for snapprotocol and snapsync.

@codecov
Copy link

codecov bot commented Aug 9, 2022 •
edited
Loading

Codecov Report

Merging #2119 (db71a41) into master (c1ee333) will increase coverage by 0.45%.
The diff coverage is n/a.

Impacted file tree graph

Flag Coverage Δ
block 83.81% <ø> (ø)
blockchain 80.54% <ø> (ø)
client 77.06% <ø> (+0.49%) ⬆️
common 95.31% <ø> (ø)
devp2p 82.50% <ø> (+0.06%) ⬆️
ethash 90.81% <ø> (ø)
evm 40.94% <ø> (ø)
statemanager 84.55% <ø> (ø)
trie 81.22% <ø> (ø)
tx 92.20% <ø> (ø)
util 87.22% <ø> (ø)
vm 78.16% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

g11tech
g11tech requested changes Aug 9, 2022
View reviewed changes
Copy link
Contributor

@g11tech g11tech left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@scorbajio i would love to see some logs of the other requests, and then encoding/decoding compared against some actual sample. Right now using our conver encoder => decoder sort of is self reinforcing, so would be awesome to test them against some actual sample data received from a geth/nethermind or other snap capable peer.

@scorbajio
Copy link
Contributor Author

@scorbajio i would love to see some logs of the other requests, and then encoding/decoding compared against some actual sample. Right now using our conver encoder => decoder sort of is self reinforcing, so would be awesome to test them against some actual sample data received from a geth/nethermind or other snap capable peer.

I'm not sure I understand what sample data you're referring to for testing encoding/decoding. Could you explain or give an example?

@g11tech
Copy link
Contributor

g11tech commented Aug 10, 2022

@scorbajio i would love to see some logs of the other requests, and then encoding/decoding compared against some actual sample. Right now using our conver encoder => decoder sort of is self reinforcing, so would be awesome to test them against some actual sample data received from a geth/nethermind or other snap capable peer.

I'm not sure I understand what sample data you're referring to for testing encoding/decoding. Could you explain or give an example?

ok, i will add the same on top of these tests, for now we can merge these ones

@g11tech g11tech changed the title client: snap tests client: snap protocol tests Aug 10, 2022
g11tech
g11tech approved these changes Aug 10, 2022
View reviewed changes
Copy link
Contributor

@g11tech g11tech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! will add more tests on top regarding encoding decoding with real data

@g11tech g11tech merged commit 77ead1b into ethereumjs:master Aug 10, 2022
@scorbajio scorbajio mentioned this pull request Oct 4, 2022
Closed
19 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@g11tech g11tech g11tech approved these changes

Assignees
No one assigned
Labels
package: client PR state: needs review type: tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@scorbajio @g11tech