Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(trie): default to false for persistRoot option #2123

Merged
merged 1 commit into from
Aug 10, 2022
Merged

refactor(trie): default to false for persistRoot option #2123

merged 1 commit into from
Aug 10, 2022

Conversation

faustbrian
Copy link
Contributor

@faustbrian faustbrian commented Aug 10, 2022 •
edited
Loading

See discussion in #2071

@faustbrian faustbrian force-pushed the trie-persist-root-default-false branch from 76ea52f to 38108af Compare August 10, 2022 13:19
@faustbrian faustbrian requested review from acolytec3 and holgerd77 and removed request for acolytec3 August 10, 2022 13:19
@codecov
Copy link

codecov bot commented Aug 10, 2022 •
edited
Loading

Codecov Report

Merging #2123 (38108af) into master (77ead1b) will decrease coverage by 0.03%.
The diff coverage is 100.00%.

Impacted file tree graph

Flag Coverage Δ
block 83.81% <ø> (ø)
blockchain 80.54% <ø> (ø)
client 77.06% <ø> (ø)
common 95.31% <ø> (ø)
devp2p 82.50% <ø> (ø)
ethash 90.81% <ø> (ø)
evm 40.94% <ø> (ø)
statemanager 84.55% <ø> (ø)
trie 81.13% <100.00%> (-0.57%) ⬇️
tx 92.20% <ø> (ø)
util 87.22% <ø> (ø)
vm 78.16% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

acolytec3
acolytec3 approved these changes Aug 10, 2022
View reviewed changes
Copy link
Contributor

@acolytec3 acolytec3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@acolytec3 acolytec3 merged commit f9b314a into master Aug 10, 2022
@acolytec3 acolytec3 deleted the trie-persist-root-default-false branch August 10, 2022 13:41
@acolytec3
Copy link
Contributor

@holgerd77 persistRoot now defaults to false :-)

gabrocheleau added a commit that referenced this pull request Aug 10, 2022
@gabrocheleau
Revert "refactor(trie): default to false for persistRoot option (#…
5895c3f 
…2123)"

This reverts commit f9b314a.
@gabrocheleau gabrocheleau mentioned this pull request Aug 10, 2022
Closed
@holgerd77
Copy link
Member

@holgerd77 persistRoot now defaults to false :-)

Thanks. 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@acolytec3 acolytec3 acolytec3 approved these changes

@holgerd77 holgerd77 Awaiting requested review from holgerd77

Assignees
No one assigned
Labels
package: mpt PR state: needs review type: refactor
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@faustbrian @acolytec3 @holgerd77