-
Notifications
You must be signed in to change notification settings - Fork 771
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: add engines
property to all package.json
files
#2164
Conversation
Codecov Report
Flags with carried forward coverage won't be shown. Click here to find out more. |
Looks good! |
Wasn't sure what to use as minimum version because there was 10, 12 and 14 but 16 is the current LTS so went with that. |
We should support v14 and beyond for now. We try to stick with supporting all NodeJS LTS versions not currently at EOL (so currently 14 and above) https://nodejs.org/en/about/releases/ |
Signed-off-by: Brian Faust <hello@basecode.sh>
@acolytec3 changed to 14 |
Signed-off-by: Brian Faust <hello@basecode.sh>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm
Yes, think 14 is a good choice, we don't want to be too aggressive here. |
Adds the
engines
property to eachpackage.json
file to make sure the minimum version is met when installing.