Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add engines property to all package.json files #2164

Merged
merged 9 commits into from
Aug 17, 2022
Merged

Conversation

faustbrian
Copy link
Contributor

Adds the engines property to each package.json file to make sure the minimum version is met when installing.

@codecov
Copy link

codecov bot commented Aug 17, 2022

Codecov Report

Merging #2164 (633f3b9) into master (f9a0471) will decrease coverage by 9.82%.
The diff coverage is n/a.

Impacted file tree graph

Flag Coverage Δ
blockchain 88.82% <ø> (?)
common 98.09% <ø> (?)
devp2p 92.25% <ø> (-0.06%) ⬇️
evm 62.96% <ø> (?)
rlp ∅ <ø> (?)
statemanager 88.66% <ø> (?)
trie 89.27% <ø> (?)
tx 97.98% <ø> (?)
util 93.14% <ø> (?)
vm 86.17% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

@gabrocheleau
Copy link
Contributor

Looks good!
Would be best however is someone else could confirm that we're fine with only supporting Node v16 and greater, ast there might be retro-compatibility considerations that I'm unaware of. @holgerd77 @acolytec3 @jochem-brouwer

gabrocheleau
gabrocheleau previously approved these changes Aug 17, 2022
@faustbrian
Copy link
Contributor Author

Wasn't sure what to use as minimum version because there was 10, 12 and 14 but 16 is the current LTS so went with that.

@acolytec3
Copy link
Contributor

We should support v14 and beyond for now. We try to stick with supporting all NodeJS LTS versions not currently at EOL (so currently 14 and above) https://nodejs.org/en/about/releases/

Signed-off-by: Brian Faust <hello@basecode.sh>
@faustbrian
Copy link
Contributor Author

@acolytec3 changed to 14

Signed-off-by: Brian Faust <hello@basecode.sh>
Copy link
Contributor

@acolytec3 acolytec3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@holgerd77
Copy link
Member

Yes, think 14 is a good choice, we don't want to be too aggressive here.

@acolytec3 acolytec3 merged commit 6c0db16 into master Aug 17, 2022
@holgerd77 holgerd77 deleted the engine-node-16 branch August 18, 2022 07:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants