refactor(trie): mark db as protected to avoid leaky properties
#2221
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Brian Faust <hello@basecode.sh>
Signed-off-by: Brian Faust <hello@basecode.sh>
Signed-off-by: Brian Faust <hello@basecode.sh>
Signed-off-by: Brian Faust <hello@basecode.sh>
Signed-off-by: Brian Faust <hello@basecode.sh>
Signed-off-by: Brian Faust <hello@basecode.sh>
Signed-off-by: Brian Faust <hello@basecode.sh>
Signed-off-by: Brian Faust <hello@basecode.sh>
Signed-off-by: Brian Faust <hello@basecode.sh>
Signed-off-by: Brian Faust <hello@basecode.sh>
Signed-off-by: Brian Faust <hello@basecode.sh>
Codecov Report
Flags with carried forward coverage won't be shown. Click here to find out more. |
faustbrian
force-pushed
the
db-protected
branch
from
fbfd5de to
c913bd2
Compare
|
@holgerd77 conflicts resolved |
|
Just ran this against my app and its test suite and all good. |
faustbrian
requested review from
holgerd77 and
jochem-brouwer
and removed request for
holgerd77
holgerd77
reviewed
Aug 24, 2022
| /** | ||
| * Flushes all checkpoints, restoring the initial checkpoint state. | ||
| */ | ||
| flushCheckpoints() { |
|
Will resolve conflicts when other PRs are sorted. |
|
@faustbrian ah, can you rather just cherry-pick the essential commits? These are only 7 or so, and then you could just solve some eventual conflicts one-by-one? With this muddling all together I am somewhat afraid that this will really head to some "big messy bunch". 😬 |
|
(so on top of a fresh |
|
Update: ah ok, maybe this works as well, we'll see. 😬 |
|
Squashed everything into a new branch. Faster than cherry picking. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
dbproperty shouldn't be accessible outside of the trie instance because we wrap it soopts.dbandthis.dbaren't equal and in general everything that can be non-public should be non-public by default. Always start with private and only work up if necessary.