Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

devp2p: remove isTruthy and isFalsy #2254

Merged
merged 3 commits into from
Aug 30, 2022
Merged

Conversation

gabrocheleau
Copy link
Contributor

Extracts devp2p from #2233

@codecov
Copy link

codecov bot commented Aug 30, 2022

Codecov Report

Merging #2254 (32f8921) into master (1c3e0e6) will increase coverage by 0.02%.
The diff coverage is 68.33%.

Impacted file tree graph

Flag Coverage Δ
block 92.83% <ø> (ø)
blockchain 88.47% <ø> (ø)
client 87.05% <ø> (ø)
common 98.09% <ø> (ø)
devp2p 92.40% <68.33%> (+0.28%) ⬆️
ethash ∅ <ø> (∅)
evm 79.11% <ø> (ø)
rlp ∅ <ø> (∅)
statemanager 88.47% <ø> (ø)
trie 89.43% <ø> (ø)
tx 97.98% <ø> (ø)
util 92.33% <ø> (ø)
vm 85.31% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

jochem-brouwer
jochem-brouwer previously approved these changes Aug 30, 2022
Copy link
Member

@jochem-brouwer jochem-brouwer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Contributor

@acolytec3 acolytec3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One minor thing but looks great otherwise!

packages/devp2p/src/protocol/les.ts Outdated Show resolved Hide resolved
gabrocheleau and others added 2 commits August 30, 2022 17:12
Co-authored-by: acolytec3 <17355484+acolytec3@users.noreply.github.com>
@gabrocheleau
Copy link
Contributor Author

Applied the minor suggestion from @acolytec3. Ready for a re-approval :)

@acolytec3 acolytec3 merged commit fababfe into master Aug 30, 2022
@holgerd77 holgerd77 deleted the devp2p/remove-isTruthy-isFalsy branch September 1, 2022 10:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants