block: remove isTruthy and isFalsy #2256
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gabrocheleau
requested review from
holgerd77,
acolytec3,
faustbrian and
jochem-brouwer
Codecov Report
Flags with carried forward coverage won't be shown. Click here to find out more. |
| const { | ||
| parentHash, | ||
| sha3Uncles, | ||
| miner, | ||
| stateRoot, | ||
| transactionsRoot, | ||
| receiptRoot, | ||
| receiptRoot, // TODO: Investigate dual receiptRoot/receiptsRoot usage. |
There was a problem hiding this comment.
This TODO can be removed, right?
There was a problem hiding this comment.
Yep, done by merging with master
packages/block/test/block.spec.ts
Outdated
| @@ -176,7 +176,7 @@ tape('[Block]: block functions', function (t) { | |||
| const common = new Common({ chain: Chain.Goerli, hardfork: Hardfork.Chainstart }) | |||
|
|
|||
| try { | |||
| blockFromRpc(testDataFromRpcGoerli, [], { common }) | |||
| blockFromRpc(testDataFromRpcGoerli as any, [], { common }) | |||
There was a problem hiding this comment.
Can cast this as JsonRPCBlock?
packages/block/test/from-rpc.spec.ts
Outdated
| common, | ||
| }) | ||
| const blockDifficultyAsInteger = blockFromRpc( | ||
| blockDataDifficultyAsInteger as any, |
There was a problem hiding this comment.
Same in this file, guess those anys can be removed/changed?
jochem-brouwer
previously approved these changes
Aug 30, 2022
|
Fixed, ready to approve @jochem-brouwer :) |
acolytec3
reviewed
Aug 31, 2022
…hereumjs/ethereumjs-monorepo into block/remove-isTruthy-isFalsy
acolytec3
approved these changes
Aug 31, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extracts block from #2233