Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

util: remove isTruthy and isFalsy #2261

Merged
merged 5 commits into from
Aug 31, 2022
Merged

util: remove isTruthy and isFalsy #2261

merged 5 commits into from
Aug 31, 2022

Conversation

gabrocheleau
Copy link
Contributor

Extracts the util package from #2233. Removes the utils themselves so should be merged once all other packages are merged.

@codecov
Copy link

codecov bot commented Aug 31, 2022 •
edited
Loading

Codecov Report

Merging #2261 (653dda8) into master (45e47e3) will increase coverage by 0.03%.
The diff coverage is 20.00%.

Impacted file tree graph

Flag Coverage Δ
block 92.89% <ø> (ø)
blockchain 88.47% <ø> (ø)
client 86.94% <ø> (ø)
common 98.09% <ø> (ø)
devp2p 92.75% <ø> (+0.35%) ⬆️
ethash ∅ <ø> (∅)
evm 79.25% <ø> (ø)
rlp ?
statemanager 88.47% <ø> (ø)
trie 89.43% <ø> (ø)
tx 97.98% <ø> (ø)
util 92.32% <20.00%> (-0.01%) ⬇️
vm 85.31% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

acolytec3
acolytec3 reviewed Aug 31, 2022
View reviewed changes
Copy link
Contributor

@acolytec3 acolytec3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, goodbye isTruthy/isFalsy

acolytec3
acolytec3 previously approved these changes Aug 31, 2022
View reviewed changes
acolytec3
acolytec3 reviewed Aug 31, 2022
View reviewed changes
Copy link
Contributor

@acolytec3 acolytec3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just noticed some lingering isTruthy in evm/tests/runCode.spec.ts too.

@gabrocheleau gabrocheleau requested a review from acolytec3 August 31, 2022 22:02
acolytec3
acolytec3 approved these changes Aug 31, 2022
View reviewed changes
Copy link
Contributor

@acolytec3 acolytec3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Never too late. Approved!

@gabrocheleau gabrocheleau merged commit 1a9da6f into master Aug 31, 2022
@gabrocheleau gabrocheleau deleted the util/remove-isTruthy-isFalsy branch August 31, 2022 22:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@acolytec3 acolytec3 acolytec3 approved these changes

Assignees
No one assigned
Labels
package: util PR state: needs review type: enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gabrocheleau @acolytec3