Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update of the skipped tests lists #231

Merged
merged 2 commits into from
Nov 18, 2017
Merged

Update of the skipped tests lists #231

merged 2 commits into from
Nov 18, 2017

Conversation

holgerd77
Copy link
Member

  • Removes now passing tests
  • Removes tests not existing any more
  • Moves some tests from the BROKEN to the PERMANENT skip list (see comments in the code)

@holgerd77
Updated Byzantium release note in README, removed Node 8 test require…
2a64566 
…ment note, added evmlab section in Debugging info
@holgerd77 holgerd77 requested a review from cdetrio November 10, 2017 12:53
@holgerd77 holgerd77 assigned jwasinger and unassigned jwasinger Nov 10, 2017
@holgerd77 holgerd77 requested a review from jwasinger November 10, 2017 12:59
jwasinger
jwasinger reviewed Nov 13, 2017
View reviewed changes
Copy link
Contributor

@jwasinger jwasinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried moving the two broken tests randomStatetest642 and randomStatetest643 into the skipBroken section and all the tests still run. Is there a reason that they need to be under skipPermanent?

@holgerd77
Removed now passing tests or tests not existing any more from the BRO…
96e9f57 
…KEN skip list, moved some tests to the permanent list
@holgerd77 holgerd77 force-pushed the skipped-tests-update branch from 9faaf8f to 96e9f57 Compare November 14, 2017 09:14
@holgerd77
Copy link
Member Author

@jwasinger I did this because randomStatetest643 is completely breaking the test run (also mentioned this in the comment after the test), so to avoid that the test run interrupts at these test when running only the broken tests.

But it's just a matter of taste, now moved the two tests to the BROKEN section and left the test above at the end of the list, should also do the job and is probably more clear that these tests should still be fixed.

@jwasinger
Copy link
Contributor

Oh I see. Hmm now that I've already reviewed once. I seem to be unable to do so again and approve/merge. wat

cdetrio
cdetrio approved these changes Nov 18, 2017
View reviewed changes
Copy link
Contributor

@cdetrio cdetrio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

only skimmed but trust its fine!

@holgerd77 holgerd77 merged commit 267f402 into master Nov 18, 2017
@holgerd77 holgerd77 deleted the skipped-tests-update branch November 18, 2017 20:05
holgerd77 added a commit that referenced this pull request Mar 11, 2021
@holgerd77
Merge pull request #231 from ethereumjs/refactorTests
3f8dc23 
Refactor test suite
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jwasinger jwasinger jwasinger left review comments

@cdetrio cdetrio cdetrio approved these changes

Assignees
No one assigned
Labels
package: vm
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@holgerd77 @jwasinger @cdetrio @evertonfraga