client: add new shanghai engine apis #2509
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files
Flags with carried forward coverage won't be shown. Click here to find out more. |
acolytec3
changed the title
g11tech
reviewed
Jan 30, 2023
g11tech
reviewed
Jan 30, 2023
g11tech
reviewed
Jan 30, 2023
g11tech
reviewed
Jan 30, 2023
g11tech
reviewed
Jan 30, 2023
g11tech
reviewed
Jan 30, 2023
g11tech
reviewed
Jan 30, 2023
Comment on lines
1047
to
1049
| for (const txn of block.transactions) { | ||
| transactions.push('0x' + txn.serialize().toString('hex')) | ||
| } |
There was a problem hiding this comment.
Suggested change
| for (const txn of block.transactions) { | |
| transactions.push('0x' + txn.serialize().toString('hex')) | |
| } | |
| const transactions = block.transactions.map((tx) => bufferToHex(tx.serialize())) ?? [] |
g11tech
reviewed
Jan 30, 2023
Comment on lines
1050
to
1055
| let withdrawals | ||
| if (block._common.gteHardfork(Hardfork.Shanghai)) { | ||
| withdrawals = [] | ||
| for (const withdrawal of block.withdrawals!) { | ||
| withdrawals.push(withdrawal.toJSON() as WithdrawalV1) | ||
| } |
There was a problem hiding this comment.
Suggested change
| let withdrawals | |
| if (block._common.gteHardfork(Hardfork.Shanghai)) { | |
| withdrawals = [] | |
| for (const withdrawal of block.withdrawals!) { | |
| withdrawals.push(withdrawal.toJSON() as WithdrawalV1) | |
| } | |
| const withdrawals = block.withdrawals?.map(wt=>wt.toJSON())??null |
we shouldn't be needing to explicity check for Shanghai as block construction would have taken care of it
g11tech
reviewed
Jan 30, 2023
| message: 'Start and Count parameters cannot be less than 1', | ||
| } | ||
| } | ||
| const currentChainHeight = (await this.chain.getCanonicalHeadHeader()).number |
There was a problem hiding this comment.
we should be able to use chain.latest.height or something since its build similarly, could avoid wait/load from db
There was a problem hiding this comment.
Good catch. Switched to this.chain.height.
g11tech
reviewed
Jan 30, 2023
| for (const block of blocks) { | ||
| try { | ||
| const transactions: string[] = [] | ||
| for (const txn of block.transactions) { |
There was a problem hiding this comment.
similar simplification for transactions and withdrawals
g11tech
changed the title
|
Nice. 👍🙂 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds new engine apis
getCapabiltiesendpoint defined here Engine API: introduce exchangeCapabilities ethereum/execution-apis#364getPayloadBodiesByHashV1from heregetPayloadBodiesByRangeV1from here