Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP - Rework CI for build jobs #2709

Closed
wants to merge 48 commits into from
Closed

WIP - Rework CI for build jobs #2709

wants to merge 48 commits into from

Conversation

acolytec3
Copy link
Contributor

@acolytec3 acolytec3 commented May 17, 2023

This PR attempts to rework our entire CI workflow so that all of the jobs that build the monorepo are consolidated into a single workflow where step 1 is a build that installs all dependencies, builds all of the packages and then caches them. Then, each of the individual package workflows just restore that build image and run that package's tests and related workflows on it.
I also added one global lint job to run all of the lint jobs at once in its own step.

@acolytec3 acolytec3 force-pushed the devp2p-timeout-fixes branch from 1e07474 to e4ecd4e Compare May 17, 2023 15:57
@codecov
Copy link

codecov bot commented May 22, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.69%. Comparing base (515a7ba) to head (78b5e49).
Report is 634 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

Flag Coverage Δ
block ?
blockchain ?
client ?
common 97.05% <ø> (ø)
devp2p ?
ethash ∅ <ø> (∅)
evm ?
rlp ?
statemanager ?
trie 89.92% <ø> (ø)
tx ?
util ?
vm 81.36% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@acolytec3 acolytec3 changed the title WIP - devp2p race condition fixes WIP - Rework CI for build jobs May 22, 2023
@acolytec3 acolytec3 force-pushed the devp2p-timeout-fixes branch from a48bcdc to 91282fe Compare May 26, 2023 18:51
@acolytec3 acolytec3 force-pushed the devp2p-timeout-fixes branch from ca56781 to 5bee0f6 Compare May 27, 2023 01:07
@holgerd77
Copy link
Member

holgerd77 commented Feb 20, 2024

Just revisting this here, cannot completely remember, what was the status of this?

Did I kill this off preliminary by being too sceptical about it? 😬 Or have there been some technical problems?

Now when revisiting I find this actually pretty solid and not really sure anymore where my biggest doubts were. 😬 😬 😬
(sorry for that eventually)

@acolytec3
Copy link
Contributor Author

Just revisting this here, cannot completely remember, what was the status of this?

Did I kill this off preliminary by being too sceptical about it? 😬 Or have there been some technical problems?

Now when revisiting I find this actually pretty solid and not really sure anymore where my biggest doubts were. 😬 😬 😬
(sorry for that eventually)

I can certainly update it and see if it still works. I don't remember your specific concerns but I think it just got forgotten about.

@holgerd77
Copy link
Member

I can certainly update it and see if it still works. I don't remember your specific concerns but I think it just got forgotten about.

👍🙂🙏

@jochem-brouwer jochem-brouwer mentioned this pull request Aug 14, 2024
3 tasks
@holgerd77
Copy link
Member

holgerd77 commented Oct 11, 2024

Super-seeded by #3592, will close

@holgerd77 holgerd77 closed this Oct 11, 2024
@holgerd77 holgerd77 deleted the devp2p-timeout-fixes branch October 11, 2024 08:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants