-
Notifications
You must be signed in to change notification settings - Fork 771
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP - Rework CI for build jobs #2709
Conversation
1e07474
to
e4ecd4e
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files
Flags with carried forward coverage won't be shown. Click here to find out more. |
devp2p
race condition fixesa48bcdc
to
91282fe
Compare
ca56781
to
5bee0f6
Compare
Just revisting this here, cannot completely remember, what was the status of this? Did I kill this off preliminary by being too sceptical about it? 😬 Or have there been some technical problems? Now when revisiting I find this actually pretty solid and not really sure anymore where my biggest doubts were. 😬 😬 😬 |
I can certainly update it and see if it still works. I don't remember your specific concerns but I think it just got forgotten about. |
👍🙂🙏 |
Super-seeded by #3592, will close |
This PR attempts to rework our entire CI workflow so that all of the jobs that build the monorepo are consolidated into a single workflow where step 1 is a
build
that installs all dependencies, builds all of the packages and then caches them. Then, each of the individual package workflows justrestore
that build image and run that package's tests and related workflows on it.I also added one global
lint
job to run all of the lint jobs at once in its own step.