Use latest rustbn.js API #312
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
axic
commented
Jul 16, 2018
lib/precompiled/08-ecpairing.js
Outdated
|
|
||
| module.exports = function (opts) { | ||
| assert(opts.data) | ||
|
|
||
| let results = {} | ||
| let data = opts.data | ||
|
|
||
| let inputHexStr = data.toString('hex') | ||
| let inputData = Buffer.from(inputHexStr, 'hex') |
There was a problem hiding this comment.
This was some funny code :)
There was a problem hiding this comment.
There was a problem hiding this comment.
I meant the fact it is doing Buffer.from(data.toString('hex'), 'hex')
axic
force-pushed
the
rustbn-update
branch
2 times, most recently
from
2ff06dd to
25eb996
Compare
|
This passes state tests 😉 |
|
Restarting the state test to check the latest merged PR (rust 1.24 support). |
|
This is waiting for the 0.2.0 release of rustbn.js |
|
Rebased again after #304. |
|
@holgerd77 ready to merge |
holgerd77
approved these changes
Jul 20, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should not be merged before the next rustbn.js release is made and
package.jsonis updated to use the release.