util: check that hex to byte conversion is valid in hexToBytes #3185
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files
Flags with carried forward coverage won't be shown. Click here to find out more. |
|
Have tested, with and without checks: |
|
Performance influence is thus neglegible, but before merging would like an opinion from @acolytec3 @holgerd77 |
acolytec3
reviewed
Dec 11, 2023
| @@ -87,8 +87,8 @@ export const hexToBytes = (hex: string): Uint8Array => { | |||
| throw new Error(`hex argument type ${typeof hex} must be of type string`) | |||
| } | |||
|
|
|||
| if (!hex.startsWith('0x')) { | |||
| throw new Error(`prefixed hex input should start with 0x, got ${hex.substring(0, 2)}`) | |||
| if (!/^0x[0-9a-fA-F]*$/.test(hex)) { | |||
There was a problem hiding this comment.
I like this approach better. Hopefully doesn't turn out to be a performance hit.
|
Did also a simple performance test here, for these kind of utility method test a simple one liner in ts-node or so also always work pretty well: console.time('t'); for (let i=0; i<100000; i++) { hexToBytes(`0x123456789${i}`) }; console.timeEnd('t');Can confirm that there seems to be no significant differences in performance. 🙂 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses an issue where an invalid hex (e.g.
'0x\x19Ethereum Signed Message:\n32')) wouldn't throw.We now validate that every parsing of hex to int (through parseInt in base 16) returns a valid int and not a NaN.