Integrate Simplified kzg-wasm Version / Deprecate Util.initKZG() #3321
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Additional note: this PR does not update the docs. I would do this along #3297 after this has been merged. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files
Flags with carried forward coverage won't be shown. Click here to find out more. |
holgerd77
force-pushed
the
integrate-new-kzg-wasm-version
branch
from
cb8ab1c
to
46fd65b
Compare
…somewhat harder cases)
|
Ok, ready for re-review respectively a final review! 🙂 |
holgerd77
added
PR state: needs review
and removed
PR state: WIP
PR state: do-not-merge
labels
g11tech
reviewed
Mar 15, 2024
packages/util/src/kzg.ts
Outdated
| */ | ||
| export function initKZG(kzgLib: Kzg, trustedSetupPath?: string) { | ||
| export function loadKZG(kzgLib: Kzg, _trustedSetupPath?: string) { | ||
| kzg = kzgLib |
There was a problem hiding this comment.
Suggested change
| kzg = kzgLib |
i don't think we need this, as well as the exported kzg object because it was earlier only used in helpers which you have updated
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR integrates a new
kzg-wasmversion from ethereumjs/kzg-wasm#6 providing a simplified interface with a direct setup loading and additionally removes the usage ofUtil.loadKZG()on the monorepo side and deprecates the respective method.Currently
kzg-wasmis referenced by Git commit, so this still needs a release before merging here.