Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
EIP-7685: Execution Layer Requests Implementation #3372
EIP-7685: Execution Layer Requests Implementation #3372
Changes from 31 commits
3735c1a
237e527
352cd93
975ab38
0f06222
74369ba
c1b725e
387af7c
43ed67d
643e96e
70ba18f
a5264d9
0bf6387
b118e5d
040f779
fc191bb
b203722
6d7e676
ad255da
de4964c
39aa2e0
2781708
52823c2
d6f70ad
a18cd5a
96ecc0a
71be096
9914dc8
1aa3bb3
cd23545
0d6feaf
6f07126
9a8258f
acd9c39
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't this check be moved into the constructor? It is possible to create a block which does not satisfy this condition by using
fromValuesArray
orfromRlpSerializedBlock
.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fair point. Will move
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just to note here that we need to be a bit careful with such
parameter
order switches (so: puttingrequests
beforeexecutionWitness
) for backwards compatibility reasons (we already have released a block library version withexecutionWitness
included. Guess in this case it should be ok though and does make sense to have this in the "correct" order from the beginning.