chore: Small cleanup to vm._emit #3396
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
roninjin10
commented
May 3, 2024
roninjin10
commented
- Move it to an instance method. There shouldn't be any issues with it being an instance method since the underlying event emitter is still per object.
- Make it more typesafe by taking keyof Events rather than string
- TODO meant to do this pr to master not vitest-update
|
I switched it over to master and looks like it's accidentally grabbed all of the commits from my PR. Maybe just cherry-pick to a new PR? |
roninjin10
force-pushed
the
roninjin10-patch-1
branch
from
8992865
to
320d8d1
Compare
|
Done! This pr is in draft only because I haven't ran any tests or typecheckers yet and my type change might break some downstream usages of the function since it's stricter now. If pr is green I'll move it out of draft. |
roninjin10
commented
May 3, 2024
roninjin10
commented
May 3, 2024
acolytec3
reviewed
May 6, 2024
- Move it to an instance method. There shouldn't be any issues with it being an instance method since the underlying event emitter is still per object. - Make it more typesafe by taking keyof Events rather than string Syntax error fix broken build run linter
roninjin10
force-pushed
the
roninjin10-patch-1
branch
from
e2fb779
to
af0ef0c
Compare
This was referenced Sep 5, 2024
This was referenced Sep 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.