Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

evm,vm: remove the hacks to prevent account cleanups of system contracts #3418

Merged
merged 4 commits into from
May 19, 2024
Merged

evm,vm: remove the hacks to prevent account cleanups of system contracts #3418

merged 4 commits into from
May 19, 2024

Conversation

g11tech
Copy link
Contributor

@g11tech g11tech commented May 13, 2024

remove some cleanup prevention hacks and add 158 cleanups to beacon block root and block root contract which would cleanup state changes if contracts are not yet deployed

(a genesis state with 4788 activated and no contract deployed for e.g. was causing consistences with block root mismatch issues)

jochem-brouwer
jochem-brouwer reviewed May 13, 2024
View reviewed changes
Copy link
Member

@jochem-brouwer jochem-brouwer left a comment •
edited by g11tech
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. However, a chain where 4788 is active but the contract is not deployed: this is undefined behavior and is not covered by the EIP. This should never be allowed. I assume this was a custom devnet?

@g11tech
Copy link
Contributor Author

g11tech commented May 13, 2024

LGTM. However, a chain where 4788 is active but the contract is not deployed: this is undefined behavior and is not covered by the EIP. This should never be allowed. I assume this was a custom devnet?

yes correct

acolytec3
acolytec3 approved these changes May 16, 2024
View reviewed changes
Copy link
Contributor

@acolytec3 acolytec3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Have merged latest master so lets merge when CI passes.

@holgerd77 holgerd77 merged commit 38c4a73 into master May 19, 2024
33 of 34 checks passed
@holgerd77 holgerd77 deleted the 158cleanup branch May 19, 2024 15:08
This was referenced Sep 5, 2024
Open
Open
Open
Open
This was referenced Sep 18, 2024
Open
Open
Open
Open
@CASABECI CASABECI mentioned this pull request Oct 5, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jochem-brouwer jochem-brouwer jochem-brouwer approved these changes

@acolytec3 acolytec3 acolytec3 approved these changes

Assignees
No one assigned
Labels
package: evm package: vm PR state: merge ready type: maintenance
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@g11tech @acolytec3 @jochem-brouwer @holgerd77