Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vm: updated 2935 tests with the new proposed bytecode and corresponding config #3438

Merged
merged 1 commit into from
May 27, 2024

Conversation

g11tech
Copy link
Contributor

@g11tech g11tech commented May 25, 2024

update the test with new proposed bytecode and deployment configs

ref:

Note: this test setup can/will be used to test various flavours of the 2935 contract as well as can be used as inspirations for other system contracts

Copy link

codecov bot commented May 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.22%. Comparing base (d24ca11) to head (54600a8).
Report is 19 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

Flag Coverage Δ
block 80.78% <ø> (?)
blockchain ?
common ?
devp2p 81.85% <ø> (?)
genesis 99.98% <ø> (?)
statemanager 74.79% <ø> (+0.48%) ⬆️
trie 59.65% <ø> (?)
util ?

Flags with carried forward coverage won't be shown. Click here to find out more.

@holgerd77
Copy link
Member

Is the discussion around this spec/code change settled(enough)?

Copy link
Member

@holgerd77 holgerd77 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nevermind, just re-read your introduction and let it sink in, will approve and merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants