Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

util,vm,evm: update the 2935 latest bytecode in test and fix address conversion issues #3447

Merged
merged 3 commits into from
Jun 12, 2024
Merged

util,vm,evm: update the 2935 latest bytecode in test and fix address conversion issues #3447

merged 3 commits into from
Jun 12, 2024

Conversation

g11tech
Copy link
Contributor

@g11tech g11tech commented Jun 7, 2024

two things:

  1. update the latest bytecode as per fixes in Update EIP-2935: Update EVM bytecode to add the system set update op ethereum/EIPs#8596
  2. fix the evm/vm code where bigint to address conversion was breaking for the addresses with leading bytes as 0

@g11tech g11tech mentioned this pull request Jun 7, 2024
Merged
2 tasks
holgerd77
holgerd77 reviewed Jun 7, 2024
View reviewed changes
Copy link
Member

@holgerd77 holgerd77 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One thing for clarification respectively to address around the new util method.

packages/util/src/bytes.ts Show resolved Hide resolved
holgerd77
holgerd77 approved these changes Jun 12, 2024
View reviewed changes
Copy link
Member

@holgerd77 holgerd77 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@holgerd77 holgerd77 merged commit fe76552 into master Jun 12, 2024
33 of 34 checks passed
@holgerd77 holgerd77 deleted the 2935-set1 branch June 12, 2024 12:54
This was referenced Sep 5, 2024
Open
Open
Open
Open
This was referenced Sep 18, 2024
Open
Open
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jochem-brouwer jochem-brouwer jochem-brouwer left review comments

@holgerd77 holgerd77 holgerd77 approved these changes

Assignees
No one assigned
Labels
package: evm package: util package: vm PR state: merge ready
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@g11tech @holgerd77 @jochem-brouwer