Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prometheus cleanup #3583

Merged
merged 3 commits into from
Aug 13, 2024
Merged

Prometheus cleanup #3583

merged 3 commits into from
Aug 13, 2024

Conversation

scorbajio
Copy link
Contributor

@scorbajio scorbajio commented Aug 13, 2024 •
edited
Loading

This change does two things:

  • clean up the Prometheus metrics server documentation for the client
  • adds a default case of returning a 404 not found response in the case of navigating to an unkown/unhandled route

holgerd77
holgerd77 approved these changes Aug 13, 2024
View reviewed changes
Copy link
Member

@holgerd77 holgerd77 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, LGTM! 🙂

@holgerd77 holgerd77 merged commit 699cde2 into master Aug 13, 2024
34 checks passed
@holgerd77 holgerd77 deleted the prometheus-cleanup branch August 13, 2024 07:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@holgerd77 holgerd77 holgerd77 approved these changes

Assignees
No one assigned
Labels
package: client PR state: needs review type: docs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@scorbajio @holgerd77