Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CHANGELOG Completion for VM v5 Release #908

Merged
merged 8 commits into from
Oct 15, 2020
Merged

CHANGELOG Completion for VM v5 Release #908

merged 8 commits into from
Oct 15, 2020

Conversation

holgerd77
Copy link
Member

Completion of the CHANGELOG files for the various libaries in preparation for the VM v5 release.

Dates on latest included merges are added to the commit messages, so some last PRs can be added upon the final release PRs (or - better - along eventually following feature PRs).

Updates here will be kept in sync with the TODO list from #907 upon pushes.

@codecov
Copy link

codecov bot commented Oct 9, 2020

Codecov Report

Merging #908 into master will increase coverage by 0.05%.
The diff coverage is n/a.

Impacted file tree graph

Flag Coverage Δ
#block 77.05% <ø> (+0.02%) ⬆️
#blockchain 80.86% <ø> (-0.31%) ⬇️
#common 93.19% <ø> (+0.17%) ⬆️
#ethash 81.81% <ø> (ø)
#tx 90.25% <ø> (-0.13%) ⬇️
#vm 87.98% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

packages/vm/CHANGELOG.md Outdated Show resolved Hide resolved
packages/vm/CHANGELOG.md Outdated Show resolved Hide resolved
cgewecke
cgewecke previously approved these changes Oct 9, 2020
Copy link
Contributor

@cgewecke cgewecke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This all makes sense & looks great to me 🎉

(Just left a couple re-wording suggestions above...)

@holgerd77
Copy link
Member Author

Rebased this, integrated the suggested re-writes and did a first write on the Bock library refactoring changes. This is still WIP (the Block CHANGELOG is more extensive than I first thought).

@holgerd77
Copy link
Member Author

Ok, this is now ready for review! 😄

Copy link
Contributor

@ryanio ryanio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

whew, big changelogs, looks really good!

@holgerd77 holgerd77 merged commit 2fe6810 into master Oct 15, 2020
@holgerd77 holgerd77 deleted the update-changelogs branch October 15, 2020 18:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants