VM speedup by using in-place bn.js operators #98
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
axic
force-pushed
the
feature/speedup
branch
2 times, most recently
from
d1fcf0a to
3dd278d
Compare
axic
force-pushed
the
feature/speedup
branch
from
3dd278d to
f367b1b
Compare
|
@cdetrio this could be taken into consideration when testing is working again |
|
This one could be merged if the tests pass. There should be a slight speed increase. |
|
It fails some tests, should be fixed. |
|
Fixed finally, should pass all tests. |
wanderer
approved these changes
Aug 10, 2017
gasolin
reviewed
Aug 11, 2017
| b = new BN(b) | ||
|
|
||
| var r | ||
| if (b.isZero()) { | ||
| r = [0] | ||
| } else { | ||
| a = new BN(a) | ||
| r = a.div(b).toArray('be', 32) |
There was a problem hiding this comment.
can do r = new BN(a).div(b).toArray('be', 32)
There was a problem hiding this comment.
All this was intentional to keep the change diff small and reviewable. It is going to be replaced by #159 anyway.
gasolin
reviewed
Aug 11, 2017
| b = utils.fromSigned(b) | ||
|
|
||
| var r | ||
| if (b.isZero()) { | ||
| r = Buffer.from([0]) | ||
| } else { | ||
| a = utils.fromSigned(a) | ||
| r = utils.toUnsigned(a.div(b)) |
There was a problem hiding this comment.
can use r = utils.toUnsigned(utils.fromSigned(a).div(b))
gasolin
reviewed
Aug 11, 2017
| b = new BN(b) | ||
| var r | ||
| if (b.isZero()) { | ||
| r = [0] | ||
| } else { | ||
| a = new BN(a) | ||
| r = a.mod(b).toArray('be', 32) |
There was a problem hiding this comment.
r = new BN(a).mod(b).toArray('be', 32)
gasolin
reviewed
Aug 11, 2017
| b = utils.fromSigned(b) | ||
| var r | ||
|
|
||
| if (b.isZero()) { | ||
| r = Buffer.from([0]) | ||
| } else { | ||
| a = utils.fromSigned(a) | ||
| r = a.abs().mod(b.abs()) |
There was a problem hiding this comment.
r = utils.fromSigned(a).abs().mod(b.abs())
gasolin
reviewed
Aug 11, 2017
| c = new BN(c) | ||
| var r | ||
|
|
||
| if (c.isZero()) { | ||
| r = [0] | ||
| } else { | ||
| a = new BN(a).iadd(new BN(b)) | ||
| r = a.mod(c).toArray('be', 32) |
gasolin
reviewed
Aug 11, 2017
| c = new BN(c) | ||
| var r | ||
|
|
||
| if (c.isZero()) { | ||
| r = [0] | ||
| } else { | ||
| a = new BN(a).imul(new BN(b)) | ||
| r = a.mod(c).toArray('be', 32) |
holgerd77
pushed a commit
that referenced
this pull request
Dec 14, 2020
* Add leveldb types * Refactor trie node * Fix lgtm warnings
holgerd77
added a commit
that referenced
this pull request
Mar 11, 2021
Update mocha to the latest version 🚀
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces #37.