Keep the stack items as an instance of bn.js #159

axic · 2017-07-28T18:15:03Z

Fixes #38. Depends on #167, #168 and #174.

axic · 2017-08-11T00:04:09Z

Down to:

# tests 2412
# pass  2323
# fail  89

axic · 2017-12-09T19:49:17Z

Rebased this locally over #174, will push once that is merged.

axic · 2017-12-10T03:27:25Z

@jwasinger I think this should work now too. Rebased and fixed some bugs.

axic · 2017-12-12T05:24:30Z

Fixed returndatasize, returndatacopy, jumpi and log. Push may be broken.

holgerd77 · 2018-01-26T11:20:58Z

Two other fixes, this is now down to 0 failures:

1..4646
# tests 4646
# pass  4646

# ok

😄

Let's wait with merging at least until Monday though, maybe someone wants to have another one-step-back view on this.

holgerd77 · 2018-01-26T11:35:14Z

Short speed comparison (on local MacBook Air) running the state tests:

feature/bn-as-stack branch: 4:04 min
master branch: 4:08 min

Hmm, seems this was more for easier reading than for speed though.

axic · 2018-01-26T11:36:22Z

lib/opFns.js

-    // NOTE: we're using a 'trick' here to get the least significant byte
-    byte = byte.toArrayLike(Buffer, 'le', 1)
+    byte = byte.toArrayLike(Buffer, 'be', 32)
+    byte = byte.slice(byte.length - 1)


Can you extract a case from the tests where this caused an issue? I'd like to figure out what is the actual reason.

node tests/tester.js -s --test='randomStatetest237' --jsontrace

In Node console:

const utils = require('ethereumjs-util') const BN = utils.BN var bn = new BN('fffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffe', 'hex') bn.toArrayLike(Buffer, 'le', 1)

gives

Error: byte array longer than desired length at assert (/Users/hdrewes/Documents/DEV/EthereumJS/ethereumjs-vm/node_modules/bn.js/lib/bn.js:6:21) at BN.toArrayLike (/Users/hdrewes/Documents/DEV/EthereumJS/ethereumjs-vm/node_modules/bn.js/lib/bn.js:527:5) at repl:1:4 at ContextifyScript.Script.runInThisContext (vm.js:44:33) at REPLServer.defaultEval (repl.js:239:29) at bound (domain.js:301:14) at REPLServer.runBound [as eval] (domain.js:314:12) at REPLServer.onLine (repl.js:440:10) at emitOne (events.js:120:20) at REPLServer.emit (events.js:210:7)

Actually this is failing for every Buffer with length > 1, e.g. also for var bn = new BN('fffe', 'hex').

Ah true, didn't in the end added the truncation support to bn.js.

Could still do Buffer.from(bn.andln(0xff))

axic · 2018-01-26T16:33:41Z

@holgerd77 that optimisation works - do you want to double check it?

holgerd77 · 2018-01-26T20:09:05Z

Should we do a minor release after this is merged?

@axic: I have to admit I'm not getting your new trick. 😎 😸

axic · 2018-01-26T20:31:33Z

.andln is bitwise AND, so basically we get the lowest 1 byte (with 0xff) out of BN. But .andln, unlike any other bn.js function, doesn't return a new BN instance, rather a Javascript number.

Sure, we can make a release.

axic · 2018-01-29T23:10:45Z

lib/opFns.js

  },
  ISZERO: function (a, runState) {
-    return new BN(a.isZero())
+    return new BN(a.isZero() ? 1 : 0)


I think these make sense, but were there actually causing an issue?

Yes, creating a BN instance from true is actually resulting in another value initialization than with 1.

> new BN(true) <BN: 7d0e> > new BN(1) <BN: 1>

Not sure if this is an error in bn.js. I find this more explicit and better to read anyway.

True, we are till using an outdated bn.js version which treated everything as a number and did random things. Finally a recent version would throw an error of invalid digit for given number base :)

axic · 2018-01-29T23:11:11Z

lib/opFns.js

  },
  EQ: function (a, b, runState) {
-    return new BN(a.cmp(b) === 0)
+    return new BN(a.cmp(b) === 0 ? 1 : 0)


Oh this code was done way before the higher level helpers were added to bn.js. We could use a.eq(b) here and above.

Created a new PR for this.

axic · 2018-01-30T11:15:15Z

@holgerd77 are you OK with squashing down the MSTORE8 changes and merging?

holgerd77 · 2018-01-30T11:47:35Z

@axic Is it possible (and did you mean that variant) squashing the MSTORE8 commit into the first one 888ed25 "Keep the stack items as BN.js instances"? Or would you (should I?) just squash the commit into the previous one? (or is there another possible way to proceed here?)

axic · 2018-01-30T11:51:42Z

@holgerd77 I'll do the squashing of that one into the original, but leaving every other fix intact.

Just asking if you are happy with the last solution?

holgerd77 · 2018-01-30T11:53:09Z

Yes. Just curious how you will do that (squashing into the original, skipping the in-between commits) Not seeing anything for that in interactive rebase command selection. Any trick?

axic · 2018-01-30T12:03:36Z

Try interactive rebase: git rebase -i HEAD~6 (offers interactive rebasing of the last 6 commits).

holgerd77 · 2018-01-30T12:07:41Z

Ah, this note "These lines can be re-ordered;" from the rebase instructions was the missing part for me, didn't know that.

axic · 2018-01-30T12:17:17Z

@holgerd77 ok to accept?

holgerd77 · 2018-01-30T12:30:31Z

Yes (the "Yes" from above was also already answering this. Sorry maybe too hidden. :-)).

holgerd77

Looks good, can be merged when tests pass.

axic · 2018-01-30T13:06:39Z

Hmm, seems this was more for easier reading than for speed though.

I think there should be a more measurable speed increase on running contracts doing arithmetics. See some of @gcolvin's benchmarks for rc5, division and exponentiation.

ci: separate browser test to own actions run

axic added the in progress label Jul 28, 2017

axic changed the title ~~Keep the stack items as an instance of bn.js~~ [WIP] Keep the stack items as an instance of bn.js Jul 28, 2017

axic force-pushed the feature/bn-as-stack branch from 22f8d4d to 906834c Compare July 28, 2017 18:44

axic force-pushed the feature/bn-as-stack branch 4 times, most recently from 2189881 to d68b535 Compare August 10, 2017 23:28

This was referenced Aug 11, 2017

VM speedup by using in-place bn.js operators #98

Merged

VM has a lot of consensus breaking bugs 🐞 #167

Closed

axic force-pushed the feature/bn-as-stack branch 6 times, most recently from 60265f7 to ce14b30 Compare August 15, 2017 00:01

axic force-pushed the feature/bn-as-stack branch from ce14b30 to cd76a34 Compare December 9, 2017 19:34

axic force-pushed the feature/bn-as-stack branch 3 times, most recently from dc3f1e0 to 3f43220 Compare December 10, 2017 03:18

axic changed the title ~~[WIP] Keep the stack items as an instance of bn.js~~ Keep the stack items as an instance of bn.js Dec 10, 2017

axic force-pushed the feature/bn-as-stack branch from 3f43220 to e6a67a3 Compare December 10, 2017 03:23

axic force-pushed the feature/bn-as-stack branch from e6a67a3 to a9f7b72 Compare December 12, 2017 05:24

jwasinger force-pushed the feature/bn-as-stack branch from a9f7b72 to dac24b2 Compare December 14, 2017 20:18

jwasinger self-assigned this Dec 15, 2017

axic force-pushed the feature/bn-as-stack branch from dac24b2 to a82a5d3 Compare December 17, 2017 21:56

jwasinger force-pushed the feature/bn-as-stack branch from a82a5d3 to 5a34c08 Compare December 18, 2017 21:20

axic commented Jan 26, 2018

View reviewed changes

axic commented Jan 29, 2018

View reviewed changes

axic and others added 4 commits January 30, 2018 12:08

Keep the stack items as BN.js instances

a0aa1df

Introduce addressToBuffer helper

4ecdf6b

Convert the storage value in SSTORE to empty Buffer when BN value is 0

8400c21

Explicit integer convert for Boolean returning opcodes

3e9b1da

axic force-pushed the feature/bn-as-stack branch from e91ce60 to 3e9b1da Compare January 30, 2018 12:08

axic mentioned this pull request Jan 30, 2018

Use bn.js eq and lt instead of cmp #254

Merged

holgerd77 approved these changes Jan 30, 2018

View reviewed changes

axic merged commit 0fba8e3 into master Jan 30, 2018

axic removed the in progress label Jan 30, 2018

axic deleted the feature/bn-as-stack branch January 30, 2018 12:46

evertonfraga added the package: vm label Feb 27, 2020

holgerd77 mentioned this pull request Sep 30, 2020

Extend Address class to handle BN ethereumjs/ethereumjs-util#276

Closed

holgerd77 added a commit that referenced this pull request May 26, 2023

Merge pull request #159 from ethereumjs/ci-separate-browser-run

83c1b1a

ci: separate browser test to own actions run

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Keep the stack items as an instance of bn.js #159

Keep the stack items as an instance of bn.js #159

axic commented Jul 28, 2017 •

edited

Loading

axic commented Aug 11, 2017

axic commented Dec 9, 2017

axic commented Dec 10, 2017

axic commented Dec 12, 2017

holgerd77 commented Jan 26, 2018

holgerd77 commented Jan 26, 2018

axic Jan 26, 2018

holgerd77 Jan 26, 2018

holgerd77 Jan 26, 2018

axic Jan 26, 2018 •

edited

Loading

axic Jan 26, 2018 •

edited

Loading

axic commented Jan 26, 2018

holgerd77 commented Jan 26, 2018

axic commented Jan 26, 2018

axic Jan 29, 2018

holgerd77 Jan 30, 2018

axic Jan 30, 2018

axic Jan 29, 2018

axic Jan 30, 2018

axic commented Jan 30, 2018

holgerd77 commented Jan 30, 2018

axic commented Jan 30, 2018

holgerd77 commented Jan 30, 2018

axic commented Jan 30, 2018

holgerd77 commented Jan 30, 2018

axic commented Jan 30, 2018

holgerd77 commented Jan 30, 2018

holgerd77 left a comment

axic commented Jan 30, 2018

Keep the stack items as an instance of bn.js #159

Keep the stack items as an instance of bn.js #159

Conversation

axic commented Jul 28, 2017 • edited Loading

axic commented Aug 11, 2017

axic commented Dec 9, 2017

axic commented Dec 10, 2017

axic commented Dec 12, 2017

holgerd77 commented Jan 26, 2018

holgerd77 commented Jan 26, 2018

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

axic Jan 26, 2018 • edited Loading

Choose a reason for hiding this comment

axic Jan 26, 2018 • edited Loading

Choose a reason for hiding this comment

axic commented Jan 26, 2018

holgerd77 commented Jan 26, 2018

axic commented Jan 26, 2018

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

axic commented Jan 30, 2018

holgerd77 commented Jan 30, 2018

axic commented Jan 30, 2018

holgerd77 commented Jan 30, 2018

axic commented Jan 30, 2018

holgerd77 commented Jan 30, 2018

axic commented Jan 30, 2018

holgerd77 commented Jan 30, 2018

holgerd77 left a comment

Choose a reason for hiding this comment

axic commented Jan 30, 2018

axic commented Jul 28, 2017 •

edited

Loading

axic Jan 26, 2018 •

edited

Loading

axic Jan 26, 2018 •

edited

Loading