This repository has been archived by the owner on Oct 30, 2024. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal:
provide node v12 support to
v0.6.x
range without breaking backwards compatProblem
no package with native perf supports node v6 and node v12 (meeting backwards compat + goal)
Proposal:
use
scryptsy
pure js implementation, and add an npm deprecation notice encouraging (upgrading or hard coding to the previous version)Cons:
lose native perf speed boost
Pros:
really good compatibility, it just works. also prods people to upgrade to latest