Skip to content
This repository has been archived by the owner on Oct 30, 2024. It is now read-only.

v0.6.x back patch: add node v12 support #114

Merged
merged 7 commits into from
Apr 28, 2020
Merged

Conversation

kumavis
Copy link
Member

@kumavis kumavis commented Apr 25, 2020

Goal:

provide node v12 support to v0.6.x range without breaking backwards compat

Problem

no package with native perf supports node v6 and node v12 (meeting backwards compat + goal)

Proposal:

use scryptsy pure js implementation, and add an npm deprecation notice encouraging (upgrading or hard coding to the previous version)

Cons:

lose native perf speed boost

Pros:

really good compatibility, it just works. also prods people to upgrade to latest

@kumavis kumavis requested a review from holgerd77 April 25, 2020 10:55
@kumavis
Copy link
Member Author

kumavis commented Apr 25, 2020

🦊 ethereumjs-wallet@0.6.x appears in MetaMask's dep graph in a few places, and is blocking our node v12 migration MetaMask/metamask-extension#8245

@kumavis kumavis marked this pull request as ready for review April 27, 2020 02:32
@kumavis
Copy link
Member Author

kumavis commented Apr 27, 2020

@holgerd77 let me know what you think 💡

@kumavis kumavis mentioned this pull request Apr 27, 2020
6 tasks
@holgerd77
Copy link
Member

Hmm, I think this is a no-go TBH since it is taking away major functionality components within a bugfix release. Any other options or suggestions?

#108 can' be taken over for Node compatibility reasons?

Copy link
Member

@holgerd77 holgerd77 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Slept over it and I think I can live with it now. It's some kind of weird mixture of properties for a bugfix release, but might be the most pragmatic solution here after all. So let's do it.

Can you prepare a release PR similar to e.g. here on this, and can you please also mention the upcoming v1.0.0 ("in the next 1-2 weeks") release? Then I will merge and publish on npm.

@holgerd77 holgerd77 merged commit 489cdbb into ethereumjs:v0.6.x Apr 28, 2020
@holgerd77 holgerd77 mentioned this pull request Apr 30, 2020
@kumavis kumavis deleted the v0.6.x branch May 7, 2020 01:22
@kumavis kumavis restored the v0.6.x branch January 18, 2021 03:50
@kumavis kumavis deleted the v0.6.x branch January 18, 2021 03:50
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants