Upgrade test suite to TS #106

ryanio · 2020-03-26T23:47:02Z

This PR:

Upgrades test suite to TypeScript
Adds new types BufferCallback and ProveCallback to satisfy implicit type errors in tests
Removes use of deprecated new Buffer()
Adds convenience script npm run benchmarks for previously existing benchmarks folder

github-actions · 2020-03-26T23:48:25Z

Coverage remained the same at 94.493% when pulling 4a6ac39 on upgradeTestsToTS into b8c50ac on master.

ryanio · 2020-03-27T00:03:07Z

I added the file renames as a separate commit to try to encourage GitHub to show the files as renamed instead of all deleted and all inserted, but I guess it didn't work for some files 🤷🏻‍♂️sorry about that, makes the diff really challenging to compare. Let me know if you have suggestions about this.

For a better diff view, see just the one commit: Upgrade tests to TS

holgerd77

First look, some questions and clarifications.

benchmarks/checkpointing.ts

holgerd77 · 2020-03-30T15:34:50Z

package.json

@@ -48,6 +49,7 @@
  ],
  "license": "MPL-2.0",
  "dependencies": {
+    "@types/async": "^3.0.8",
    "async": "^2.6.1",


We want at some point getting rid of the async dependencies - just as a side note - see issue here ethereumjs/organization#55

ah ok thanks

Oops this should be in devDeps, I’ll move it

Oh, you are right. Already merged, just do a short follow-up PR eventually.

No prob, will include in next PR for promisify work, hopefully today or tomorrow.

package.json

holgerd77 · 2020-03-30T15:45:29Z

package.json

@@ -8,6 +8,7 @@
    "dist/**/*"
  ],
  "scripts": {
+    "benchmarks": "npm run build && ts-node benchmarks/index.ts",


Ah, didn't see this when doing the comment on the benchmark files above.

However this fails for me with a completely fresh node module reinstall with several implicit any type errors. Any comment on that?

Thanks, I just did a fresh install and ran into the errors, will look at fixing. edit: should be fixed with latest commit now

Can confirm that this works now.

src/baseTrie.ts

holgerd77

Ok, just skimmed through all the code parts. Most code changes are minor (type additions, syntax updates,..) and pretty much local, think we can very well merge here. Thanks a lot Ryan! 😄

Will directly do the merge.

holgerd77 · 2020-03-30T20:14:23Z

benchmarks/random.js

-const async = require('async')
+import * as async from 'async'
+import * as ethUtil from 'ethereumjs-util'
+const Trie = require('../dist/index.js').BaseTrie


Just as a note: benchmarks now moved to be run on dist.

ryanio added 2 commits March 26, 2020 16:56

Upgrade tests to TS

469e88e

Rename files

5d75653

ryanio force-pushed the upgradeTestsToTS branch from 4a6ac39 to 5d75653 Compare March 26, 2020 23:58

ryanio added the PR state: needs review label Mar 27, 2020

holgerd77 reviewed Mar 30, 2020

View reviewed changes

Fix benchmark implicit type errors

67e1b58

holgerd77 approved these changes Mar 30, 2020

View reviewed changes

holgerd77 merged commit 3b37de5 into master Mar 30, 2020

holgerd77 deleted the upgradeTestsToTS branch March 30, 2020 20:35

ryanio mentioned this pull request Apr 17, 2020

Release - v4.0.0 #111

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Upgrade test suite to TS #106

Upgrade test suite to TS #106

ryanio commented Mar 26, 2020 •

edited

Loading

github-actions bot commented Mar 26, 2020

ryanio commented Mar 27, 2020 •

edited

Loading

holgerd77 left a comment

holgerd77 Mar 30, 2020

ryanio Mar 30, 2020

ryanio Mar 30, 2020 •

edited

Loading

holgerd77 Mar 30, 2020

ryanio Mar 30, 2020

holgerd77 Mar 30, 2020

ryanio Mar 30, 2020 •

edited

Loading

holgerd77 Mar 30, 2020

holgerd77 left a comment

holgerd77 Mar 30, 2020

Upgrade test suite to TS #106

Upgrade test suite to TS #106

Conversation

ryanio commented Mar 26, 2020 • edited Loading

github-actions bot commented Mar 26, 2020

ryanio commented Mar 27, 2020 • edited Loading

holgerd77 left a comment

Choose a reason for hiding this comment

holgerd77 Mar 30, 2020

Choose a reason for hiding this comment

ryanio Mar 30, 2020

Choose a reason for hiding this comment

ryanio Mar 30, 2020 • edited Loading

Choose a reason for hiding this comment

holgerd77 Mar 30, 2020

Choose a reason for hiding this comment

ryanio Mar 30, 2020

Choose a reason for hiding this comment

holgerd77 Mar 30, 2020

Choose a reason for hiding this comment

ryanio Mar 30, 2020 • edited Loading

Choose a reason for hiding this comment

holgerd77 Mar 30, 2020

Choose a reason for hiding this comment

holgerd77 left a comment

Choose a reason for hiding this comment

holgerd77 Mar 30, 2020

Choose a reason for hiding this comment

ryanio commented Mar 26, 2020 •

edited

Loading

ryanio commented Mar 27, 2020 •

edited

Loading

ryanio Mar 30, 2020 •

edited

Loading

ryanio Mar 30, 2020 •

edited

Loading