Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

EIP155 sign check add api #8

Merged
merged 1 commit into from
Aug 23, 2022
Merged

EIP155 sign check add api #8

merged 1 commit into from
Aug 23, 2022

Conversation

CrisChain
Copy link

EIP155 sign check add api

@CrisChain
EIP155 sign check add api
ddf3069 
EIP155 sign check add  api
@ethereumpow
Copy link
Owner

accept pull。thx bro

@ethereumpow ethereumpow merged commit ba11b93 into ethereumpow:master Aug 23, 2022
@ethereumpow ethereumpow requested a review from dddccc1984 August 24, 2022 04:25
dddccc1984
dddccc1984 reviewed Aug 26, 2022
View reviewed changes
Copy link
Collaborator

@dddccc1984 dddccc1984 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should return the same error
return common.Hash{}, errors.New("only replay-protected (EIP-155) transactions allowed over RPC")

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dddccc1984 dddccc1984 dddccc1984 left review comments

@ethereumpow ethereumpow ethereumpow approved these changes

@Paul286 Paul286 Paul286 approved these changes

@gobitfree gobitfree Awaiting requested review from gobitfree

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@CrisChain @ethereumpow @Paul286 @dddccc1984