Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FunctionFragment format(FormatType.json) has two typos #1275

Closed
cryppadotta opened this issue Feb 3, 2021 · 3 comments
Closed

FunctionFragment format(FormatType.json) has two typos #1275

cryppadotta opened this issue Feb 3, 2021 · 3 comments
Labels
bug Verified to be an issue. fixed/complete This Bug is fixed or Enhancement is complete and published.

Comments

@cryppadotta
Copy link

cryppadotta commented Feb 3, 2021

When you try to format a fragment using JSON, there are two typos.

  • payble should be payable
  • ouputs should be outputs

payble: this.payable,
gas: (this.gas ? this.gas.toNumber(): undefined),
inputs: this.inputs.map((input) => JSON.parse(input.format(format))),
ouputs: this.outputs.map((output) => JSON.parse(output.format(format))),
});

@ricmoo ricmoo added bug Verified to be an issue. on-deck This Enhancement or Bug is currently being worked on. labels Feb 3, 2021
@ricmoo
Copy link
Member

ricmoo commented Feb 3, 2021

Wow... How has that not been noticed before? I will get to this right away.

(maybe I should use strings for dictionary keys in the future so the spell-checker can pick up on these)

@ricmoo
Copy link
Member

ricmoo commented Feb 3, 2021

This should be fixed in 5.0.29. Please try it out and let me know if you have any more issues.

Thanks! :)

@ricmoo ricmoo added fixed/complete This Bug is fixed or Enhancement is complete and published. and removed on-deck This Enhancement or Bug is currently being worked on. labels Feb 3, 2021
@ricmoo
Copy link
Member

ricmoo commented Feb 8, 2021

Closing this now, but if you have any issues with the fix or in general, please feel free to re-open.

Thanks! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Verified to be an issue. fixed/complete This Bug is fixed or Enhancement is complete and published.
Projects
None yet
Development

No branches or pull requests

2 participants