-
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FunctionFragment format(FormatType.json) has two typos #1275
Labels
bug
Verified to be an issue.
fixed/complete
This Bug is fixed or Enhancement is complete and published.
Comments
ricmoo
added
bug
Verified to be an issue.
on-deck
This Enhancement or Bug is currently being worked on.
labels
Feb 3, 2021
Wow... How has that not been noticed before? I will get to this right away. (maybe I should use strings for dictionary keys in the future so the spell-checker can pick up on these) |
ricmoo
added a commit
that referenced
this issue
Feb 3, 2021
This should be fixed in 5.0.29. Please try it out and let me know if you have any more issues. Thanks! :) |
ricmoo
added
fixed/complete
This Bug is fixed or Enhancement is complete and published.
and removed
on-deck
This Enhancement or Bug is currently being worked on.
labels
Feb 3, 2021
Closing this now, but if you have any issues with the fix or in general, please feel free to re-open. Thanks! :) |
This was referenced Mar 12, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
bug
Verified to be an issue.
fixed/complete
This Bug is fixed or Enhancement is complete and published.
When you try to format a fragment using JSON, there are two typos.
payble
should bepayable
ouputs
should beoutputs
ethers.js/packages/abi/src.ts/fragments.ts
Lines 820 to 824 in 8e3cfd8
The text was updated successfully, but these errors were encountered: