Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Documentation: signMessage input format not specified #1343

Closed
wjmelements opened this issue Mar 10, 2021 · 4 comments
Closed

Documentation: signMessage input format not specified #1343

wjmelements opened this issue Mar 10, 2021 · 4 comments
Labels
documentation Documentation related issue.

Comments

@wjmelements
Copy link

From EIP 191 I would expect a text signing method to detail how the signature is made. Does it use \x19Ethereum Signed Message:\n?
@ricmoo
Copy link
Member

ricmoo commented Mar 10, 2021

It’s mentioned here but I should probably add it to the Signer docs too.

@ricmoo ricmoo added the documentation Documentation related issue. label Mar 10, 2021
@wjmelements
Copy link
Author

Thanks, the hashMessage docs were just what I was looking for! If you would link that description in the signMessage docs that would help future engineers.

@ricmoo
Copy link
Member

ricmoo commented Mar 10, 2021

Agreed. :)

ricmoo added a commit that referenced this issue Jun 24, 2021
@ricmoo
docs: Added info on signMessage (#1343).
f9d0964
@ricmoo
Copy link
Member

ricmoo commented Aug 9, 2021

Looks like I did this a while ago. :)

Thanks! :)

@ricmoo ricmoo closed this as completed Aug 9, 2021
@snyk-bot snyk-bot mentioned this issue Sep 6, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
documentation Documentation related issue.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@wjmelements @ricmoo