Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add confirmations to TransactionResponse #4094

Closed
mqklin opened this issue May 28, 2023 · 1 comment
Closed

Add confirmations to TransactionResponse #4094

mqklin opened this issue May 28, 2023 · 1 comment
Labels
enhancement New feature or improvement. fixed/complete This Bug is fixed or Enhancement is complete and published. minor-bump Planned for the next minor version bump. v6 Issues regarding v6

Comments

@mqklin
Copy link

mqklin commented May 28, 2023 •
edited
Loading

Describe the Feature

Right now there is confirmations field only for TransactionReceipt objects. But in v5 it was also in TransactionResponse, which is handy.

Code Example

const mined = (await Provider.getTransaction(sentTx.hash)).confirmations > 0
@mqklin mqklin added the enhancement New feature or improvement. label May 28, 2023
@ricmoo
Copy link
Member

ricmoo commented May 28, 2023

This absolutely makes sense and I’ll get it into the next minor bump. Thanks! :)

@ricmoo ricmoo added minor-bump Planned for the next minor version bump. v6 Issues regarding v6 on-deck This Enhancement or Bug is currently being worked on. labels May 28, 2023
ricmoo added a commit that referenced this issue Jun 7, 2023
@ricmoo
Add confirmations to TransactionResponse (#4094).
bb8685b
@ricmoo ricmoo added fixed/complete This Bug is fixed or Enhancement is complete and published. and removed on-deck This Enhancement or Bug is currently being worked on. labels Jun 8, 2023
@ricmoo ricmoo closed this as completed Jul 24, 2023
Woodpile37 pushed a commit to Woodpile37/ethers.js that referenced this issue Jan 14, 2024
@ricmoo @Woodpile37
Add confirmations to TransactionResponse (ethers-io#4094).
cd22879
Woodpile37 pushed a commit to Woodpile37/ethers.js that referenced this issue Jan 14, 2024
@ricmoo @Woodpile37
Add confirmations to TransactionResponse (ethers-io#4094).
bb9ddb9
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or improvement. fixed/complete This Bug is fixed or Enhancement is complete and published. minor-bump Planned for the next minor version bump. v6 Issues regarding v6
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ricmoo @mqklin