-
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve getDefaultProvider types #4501
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The first argument to the function was actually optional, but had a required type.
ricmoo
changed the title
🐛 Improve getDefaultProvider types
Improve getDefaultProvider types
Feb 1, 2024
ricmoo
added
enhancement
New feature or improvement.
on-deck
This Enhancement or Bug is currently being worked on.
minor-bump
Planned for the next minor version bump.
v6
Issues regarding v6
next-patch
Issues scheduled for the next arch release.
labels
Feb 1, 2024
ricmoo
added a commit
that referenced
this pull request
Feb 2, 2024
Merged into v6.11.0. Thanks! :) |
ricmoo
added
fixed/complete
This Bug is fixed or Enhancement is complete and published.
and removed
on-deck
This Enhancement or Bug is currently being worked on.
next-patch
Issues scheduled for the next arch release.
labels
Feb 10, 2024
This was referenced May 22, 2024
This was referenced Jun 20, 2024
This was referenced Jun 23, 2024
This was referenced Sep 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
enhancement
New feature or improvement.
fixed/complete
This Bug is fixed or Enhancement is complete and published.
minor-bump
Planned for the next minor version bump.
v6
Issues regarding v6
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm using ethers + typescript and I'm forced to call the provider this way:
The problem is that getDefaultProvider types require passing a first argument, although in fact it is optional. As a result, I have to cheat with typescript just to run the code. I add just one character to the codebase and the first argument becomes optional, which it really is. This seems to improve the development experience, take a look at the new code: