Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): update linter version to make linting work on macs with M1 #2407

Merged
merged 1 commit into from
Aug 16, 2021

Conversation

vojtechsimetka
Copy link
Contributor

@vojtechsimetka vojtechsimetka commented Aug 13, 2021

Updated to the earliest version that supports M1 chip. This should not change any linter rules. See the corresponding issue golangci/golangci-lint#1725

Feel free to reject this if you have different workflow to update dependencies.

NOTE: tests still don't work as these would require beekeeper to be compiled to M1 chip

before:
make lint

test -f $(go env GOPATH)/bin/golangci-lint || curl -sSfL https://raw.githubusercontent.com/golangci/golangci-lint/master/install.sh | sh -s -- -b $(go env GOPATH)/bin v1.30.0
golangci/golangci-lint info checking GitHub for tag 'v1.30.0'
golangci/golangci-lint info found version: 1.30.0 for v1.30.0/darwin/arm64
make: *** [linter] Error 1

after:
make lint

test -f $(go env GOPATH)/bin/golangci-lint || curl -sSfL https://raw.githubusercontent.com/golangci/golangci-lint/master/install.sh | sh -s -- -b $(go env GOPATH)/bin v1.37.0
$(go env GOPATH)/bin/golangci-lint run

This change is Reviewable

@acud
Copy link
Member

acud commented Aug 16, 2021

D'

@acud acud merged commit ad10062 into ethersphere:master Aug 16, 2021
@acud
Copy link
Member

acud commented Aug 16, 2021

@vojtechsimetka next time you could PR from a branch inside the bee repo, this will make all tests run on the CI (some tokens are not included when PRing from private forks)

@vojtechsimetka
Copy link
Contributor Author

@acud That was my intention but I do not have write access to the repo 😬

@vojtechsimetka vojtechsimetka deleted the fix/make-on-M1-mac branch August 16, 2021 13:04
@acud acud added this to the v1.2.0 milestone Sep 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants