This repository has been archived by the owner on Aug 2, 2021. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For many packages we have only one code owner and their approval is a must when merging a PR. What happens when these people go on vacation for example? (see ethereum/go-ethereum#18386) - we won’t be able to merge anything in swarm/api/http when @justelad is on vacation.
We must add at least 2-3 code owners to every single package, or get rid of them altogether.
I don’t really like adding many code owners, because then you have a PR with 4-5 reviewers, and noone feels responsible for reviewing the PR.
Therefore I suggest we remove all the codeowners from .github. What do you think?
I think we all have a good idea of who knows which part of the codebase best, and can make a good educated guess who to add as a reviewer, without the need for codeowners.