Add nonce key param on all wallets #101
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ch4r10t33r
approved these changes
Feb 7, 2024
| @@ -84,13 +84,12 @@ export class SimpleAccountAPI extends BaseAccountAPI { | |||
| return this.accountAddress; | |||
| } | |||
|
|
|||
| async getNonce(): Promise<BigNumber> { | |||
| async getNonce(key = 0): Promise<BigNumber> { | |||
| console.log('checking nonce...'); | |||
There was a problem hiding this comment.
Can we please remove the console.log?
src/sdk/base/ZeroDevWalletAPI.ts
Outdated
| @@ -117,13 +117,12 @@ export class ZeroDevWalletAPI extends BaseAccountAPI { | |||
| return this.accountAddress; | |||
| } | |||
|
|
|||
| async getNonce(): Promise<BigNumber> { | |||
| async getNonce(key = 0): Promise<BigNumber> { | |||
| console.log('checking nonce...'); | |||
arddluma
requested changes
Feb 8, 2024
arddluma
reviewed
Feb 8, 2024
CHANGELOG.md
Outdated
| @@ -1,5 +1,9 @@ | |||
| # Changelog | |||
| ## [1.4.2] - 2024-01-26 | |||
| ## [1.5.1] - 2024-01-26 | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Types of changes
What types of changes does your code introduce?
Further comments (optional)